-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ruff for our python lints #1378
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's delete .flake8
too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so nice!
@@ -2,6 +2,7 @@ | |||
// See https://go.microsoft.com/fwlink/?LinkId=827846 | |||
// for the documentation about the extensions.json format | |||
"recommendations": [ | |||
"charliermarsh.ruff", // Ruff for linting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
niiiice
* Switch linting to ruff * Updates from ruff linter * Format pyproject.toml * Document the ruff configuration * Remove .flake8 * Add recommendation for ruff extension and config to use our pyproject.toml
Ruff seems likely to be faster and more stable, though it did want to re-sort a lot of our imports.
These mostly seem to make sense, since from the perspective of examples,
rerun
is just another external dep and should be sorted as such.And looks to run consistently in CI:
#1377
Checklist
CHANGELOG.md
(if this is a big enough change to warrant it)