Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify the time formatting between the time panel and the plot #1369

Merged
merged 3 commits into from
Feb 22, 2023
Merged

Unify the time formatting between the time panel and the plot #1369

merged 3 commits into from
Feb 22, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Feb 21, 2023 •
edited
Loading

…improving the formatting of the dates and times in both!

image

Top: plot, bottom: timepanel

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

@emilk emilk added ui concerns graphical user interface 📺 re_viewer affects re_viewer itself labels Feb 21, 2023
@Wumpf Wumpf self-requested a review February 22, 2023 12:52
Wumpf
Wumpf approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat!

crates/re_log_types/src/time.rs Show resolved Hide resolved
@emilk emilk merged commit 0bc2e89 into main Feb 22, 2023
@emilk emilk deleted the emilk/unify-time-formatting branch February 22, 2023 13:20
@emilk emilk mentioned this pull request Feb 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
📺 re_viewer affects re_viewer itself ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @Wumpf