Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor analytics #1368

Merged
merged 10 commits into from
Feb 21, 2023
Merged

Refactor analytics #1368

merged 10 commits into from
Feb 21, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Feb 21, 2023 •
edited
Loading

This PR aims to make the analytics even more transparent.

All analytics collected by the viewer is now found in crates/re_viewer/src/viewer_analytics.rs.

This is a pure refactor, with ONE exception: the update_metadata event (the first sent) now has an event_id, just like every other event. It is assigned event_id=0.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

@emilk emilk added 🧑‍💻 dev experience developer experience (excluding CI) 📖 documentation Improvements or additions to documentation labels Feb 21, 2023
emilk
emilk commented Feb 21, 2023
View reviewed changes
crates/re_analytics/src/lib.rs Outdated Show resolved Hide resolved
@emilk emilk marked this pull request as ready for review February 21, 2023 11:09
@teh-cmc teh-cmc self-requested a review February 21, 2023 11:25
teh-cmc
teh-cmc approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@emilk emilk merged commit 59639c8 into main Feb 21, 2023
@emilk emilk deleted the emilk/refactor-analytics branch February 21, 2023 12:34
@emilk emilk added the 📊 analytics telemetry analytics label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teh-cmc teh-cmc teh-cmc approved these changes

Assignees
No one assigned
Labels
📊 analytics telemetry analytics 🧑‍💻 dev experience developer experience (excluding CI) 📖 documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @teh-cmc