Improve the gap-detector #1363
Merged
Improve the gap-detector #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
🪳 bug
teh-cmc
approved these changes
Feb 21, 2023
| // This is partially an optimization, and partially something that "feels right". | ||
| let min_gap_size: u64 = match time_type { | ||
| TimeType::Sequence => 9, | ||
| TimeType::Time => 100_000_000, // nanos! |
There was a problem hiding this comment.
Suggested change
| TimeType::Time => 100_000_000, // nanos! | |
| TimeType::Time => 100_000_000, // 100ms |
There was a problem hiding this comment.
I sort of prefer the reader having to do their own math rather than adding a comment that is going to be outdated the next time someone changes that line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sparked by #1358
In the time panel we collapse large gaps in the data so that if you record a few minutes today and a few minutes tomorrow you won't need to scroll and zoom so much. But when is a gap big enough to warrant collapse?
The previous logic could sometimes produce way too many collapsed gaps, sapping performance and usability.
This PR changes the logic completely. The new logic only collapses a gap if it would shrink the whole timeline by at least some significant amount, which right now is hard-coded to 35% (more if there is very few datapoints). It also adds a new upper limit, so that we never collapse more than 20 gaps.
At the end of the day, this is just an improved heuristic, and still not "perfect", whatever that would mean.
Checklist
CHANGELOG.md(if this is a big enough change to warrant it)