Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document undocumented environment variables on --help #1335

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Document undocumented environment variables on --help #1335

merged 1 commit into from
Feb 17, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Feb 16, 2023

Sister PR to rerun-io/rerun-docs#46
Followup to #1332

@teh-cmc does it make any sense at all to document RERUN_SHADER_PATH here?

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

@Wumpf Wumpf changed the title Document undocumented environment variables on help page. Document undocumented environment variables on --help Feb 16, 2023
@Wumpf Wumpf added the 📖 documentation Improvements or additions to documentation label Feb 16, 2023
emilk
emilk approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@emilk emilk merged commit 1184c20 into main Feb 17, 2023
@emilk emilk deleted the andreas/missing-environment-variables-from-help branch February 17, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
📖 documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wumpf @emilk