Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rerun_demo default to the cube #1301

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Make rerun_demo default to the cube #1301

merged 2 commits into from
Feb 14, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Feb 14, 2023

python -m rerun_demo             # runs cube demo
python -m rerun_demo --cube      # runs cube demo
python -m rerun_demo --colmap    # runs colmap demo

Screen shot for first run on a fresh app instance:
image

Because we're calling the colmap demo --colmap I also named the rrd file as such.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

@jleibs jleibs marked this pull request as ready for review February 14, 2023 17:21
@jleibs jleibs added the 📖 documentation Improvements or additions to documentation label Feb 14, 2023
@jleibs
Copy link
Member Author

jleibs commented Feb 14, 2023

Downloaded wheel from artifacts and confirmed it has correct rrd file and runs as expected.

Copy link
Member

@nikolausWest nikolausWest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@jleibs jleibs merged commit 4817279 into main Feb 14, 2023
@jleibs jleibs deleted the jleibs/cube_demo branch February 14, 2023 19:04
@jleibs jleibs mentioned this pull request Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants