Source default batcher settings from sink #10620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
added
include in changelog
🪵 Log & send APIs
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
|
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
teh-cmc
approved these changes
Jul 15, 2025
Wumpf
force-pushed
the
andreas/sink-dependent-default-flush-settings
branch
from
b571e5f to
ab3095e
Compare
teh-cmc
reviewed
Jul 15, 2025
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/16292479612 |
teh-cmc
added a commit
that referenced
this pull request
Jul 16, 2025
) ### What We changed the behavior of the batcher in: #10620 However, the only way to override this behavior was to set environment variables, which can be tricky/annoying in some circumstances. This plumbs through the configuration settings so that this can be specified explicitly now. --------- Co-authored-by: Clement Rey <[email protected]>
emilk
added a commit
that referenced
this pull request
Aug 6, 2025
### Related * Introduced in #10620 ### What Environment variables are annoying
emilk
added a commit
that referenced
this pull request
Aug 6, 2025
### Related * Introduced in #10620 ### What Environment variables are annoying
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
Makes the default flush tick 200ms for file & memory sinks and leaves it at 8ms for grpc sinks.
To facilitate this, I introduced per sink batcher config defaults and had to make the batcher configuration updatable (since Python always first creates a recording stream with a memory sink and then patches it in later). Unfortunately not all config optionscan be updated after the fact, but I think the solution here is good enough for what is practically needed.