Skip to content

Make SeriesPoints::markers component required #10572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 10, 2025
Merged

Make SeriesPoints::markers component required #10572

merged 9 commits into from
Jul 10, 2025

Conversation

grtlr
Copy link
Contributor

@grtlr grtlr commented Jul 9, 2025 •
edited
Loading

Related

TODO

  • full-check

@grtlr grtlr added include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages labels Jul 9, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2025 •
edited
Loading

Latest documentation preview deployed successfully.

Result Commit Link
✅ 8ef4662 https://landing-e1eq6wng7-rerun.vercel.app/docs

Note: This comment is updated whenever you push a commit.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2025 •
edited
Loading

Web viewer failed to build.

| Result | Commit | Link | Manifest |
| ------ | ------- | ----- |
| ❌ | | https://rerun.io/viewer/pr/10572 | +nightly +main |

Note: This comment is updated whenever you push a commit.

@grtlr grtlr mentioned this pull request Jul 9, 2025
Open
3 tasks
@grtlr grtlr marked this pull request as draft July 9, 2025 14:50
@grtlr grtlr marked this pull request as ready for review July 9, 2025 15:17
@grtlr
Copy link
Contributor Author

grtlr commented Jul 9, 2025

@rerun-bot full-check

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2025

Started a full build: https://github.com/rerun-io/rerun/actions/runs/16173341913

@grtlr grtlr force-pushed the grtlr/marker-required branch from 7a57d27 to 8bee894 Compare July 9, 2025 15:19
emilk
emilk approved these changes Jul 10, 2025
View reviewed changes
emilk
emilk reviewed Jul 10, 2025
View reviewed changes
@grtlr
Copy link
Contributor Author

grtlr commented Jul 10, 2025

@rerun-bot full-check

@github-actions GitHub Actions
Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/16189711885

@grtlr grtlr mentioned this pull request Jul 10, 2025
Merged
3 tasks
@emilk emilk requested a review from Wumpf July 10, 2025 09:38
Wumpf
Wumpf approved these changes Jul 10, 2025
View reviewed changes
@grtlr grtlr merged commit 04fb105 into main Jul 10, 2025
34 of 35 checks passed
@grtlr grtlr deleted the grtlr/marker-required branch July 10, 2025 12:36
grtlr added a commit that referenced this pull request Jul 10, 2025
@grtlr @Wumpf
Remove indicators from codegen, rerun_py, and rerun_cpp (#10581)
9211056 
### Related

* Part of #6889
* Part of #8129
* [x] Merge after #10572.

### What

Title. 🎉 

### TODO

* [x] full-check
* [x] No changes required on dataplatform side.

---------

Co-authored-by: Andreas Reich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grtlr @emilk @Wumpf