Skip to content

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Jun 27, 2025

Related

What

This add a partition_id field to the TimeUpdateEvent send from the viewer to the notebook. It is set to the current partition id for a remote partition, and None otherwise.

Copy link

github-actions bot commented Jun 27, 2025

Web viewer built successfully. If applicable, you should also test it:

  • I have tested the web viewer
Result Commit Link Manifest
a66e86f https://rerun.io/viewer/pr/10403 +nightly +main

Note: This comment is updated whenever you push a commit.

@abey79 abey79 added notebook Jupyter notebooks etc include in changelog sdk-python Python logging API labels Jun 27, 2025
Copy link
Member

@jprochazk jprochazk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comment at the top of this file:

// NOTE: Any changes to the type definitions in this file must be replicated in:
// - rerun_js/web-viewer/index.ts (ViewerEvent)
// - rerun_py/rerun_sdk/rerun/event.py (ViewerEvent)

Both the JS and Python callbacks need to be updated. The JS stuff is here:

type ViewerEventBase = {
application_id: string;
recording_id: string;
}

@abey79 abey79 merged commit 97ed174 into main Jun 27, 2025
41 checks passed
@abey79 abey79 deleted the antoine/partition-id-event branch June 27, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
include in changelog notebook Jupyter notebooks etc sdk-python Python logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Route PartitionID through event callbacks
2 participants