Support for seconds-since-Epoch numpy arrays for constructing TimeColumn
#10168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…__() Apply the equivalent of the conversion that is done for the duration kwarg. Fixes accidental interpretation of seconds as nanoseconds. Closes: rerun-io#10167
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi! Thanks for opening this pull request.
Because this is your first time contributing to this repository, make sure you've read our Contributor Guide and Code of Conduct.
MichaelGrupp
commented
Jun 8, 2025
Wumpf
requested changes
Jun 9, 2025
MichaelGrupp
commented
Jun 9, 2025
| ], | ||
| type=pa.timestamp("ns"), | ||
| ), | ||
| ), |
There was a problem hiding this comment.
Same test fixture as the one for plain lists above, but with np.array.
Wumpf
changed the title
TimeColumn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the equivalent of the conversion that is done for the
durationkwarg.Fixes accidental interpretation of seconds as nanoseconds.
Closes: #10167