Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for RowIdColumnDescriptor to re_sorbet::ColumnDescriptor #9034

Open
abey79 opened this issue Feb 13, 2025 · 0 comments
Open

Add support for RowIdColumnDescriptor to re_sorbet::ColumnDescriptor #9034

abey79 opened this issue Feb 13, 2025 · 0 comments
Labels
🔩 data model Sorbet feat-dataframe-api Everything related to the dataframe API

Comments

@abey79
Copy link
Member

abey79 commented Feb 13, 2025

As the title say. It has implications on the dataframe API though, which currently does not expose row id.
@abey79 abey79 added ui concerns graphical user interface 🔩 data model Sorbet feat-dataframe-api Everything related to the dataframe API and removed ui concerns graphical user interface labels Feb 13, 2025
@abey79 abey79 mentioned this issue Feb 14, 2025
Merged
abey79 added a commit that referenced this issue Feb 16, 2025
@abey79
Add ComponentDescriptorRef to re_sorbet (#9043)
1ee93eb 
### Related

* Related to #9034
* Required for #9018 

### What

This PR introduce the `ComponentDescriptorRef` type to `re_sorbet`. It's
like `ComponentDescriptor` but:
- It has refs instead of owned copies.
- It has a `RowId` enum (which would be difficult to add to
`ComponentDescriptor` because of the ramifications on the dataframe
API—let's wait for the RowID <-> Index column merge for that).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🔩 data model Sorbet feat-dataframe-api Everything related to the dataframe API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abey79