Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI Design for a "No Data" page when the Welcome screen has been disabled #6263

Closed
jleibs opened this issue May 7, 2024 · 2 comments · Fixed by #6287
Closed

UI Design for a "No Data" page when the Welcome screen has been disabled #6263

jleibs opened this issue May 7, 2024 · 2 comments · Fixed by #6287
Assignees
@abey79
Labels
ui concerns graphical user interface

Comments

@jleibs
Copy link
Member

jleibs commented May 7, 2024

This was motivated by use-cases where Rerun is being embedded in another product context. Indirect users (those that have not logged the data and know nothing about Rerun) aren't sure what to do with the Welcome screen.

However, the question is what do we show in this case when all the recordings have been closed.

Ideally we would have something that looked nicer than this while fitting within the spirit of
image
@jleibs jleibs added the ui concerns graphical user interface label May 7, 2024
@jleibs jleibs mentioned this issue May 7, 2024
Merged
5 tasks
@abey79
Copy link
Member

abey79 commented May 8, 2024

@nikolausWest We could do with your input here. I see two possible avenue: either fully minimalist, or we inject a little bit of context about the viewer is about using a light version of the welcome screen.

Minimalist

Just to pieces of copy, in weak still:

  • placeholder where the recording would show up
  • placeholder in the middle of the viewport

Image

Light welcome screen

  • Same "no recording" placeholder
  • Similar heading as the current welcome screen, though the copy might have to be adjusted to be not too surprising for "data-consumer"-type users

Image

@abey79
Copy link
Member

abey79 commented May 10, 2024

Let's start with this version, with "No recordings loaded" as copy in the recording list.

image

@abey79 abey79 mentioned this issue May 10, 2024
Merged
5 tasks
jleibs added a commit that referenced this issue May 10, 2024
@jleibs
Add a new CLI option / spawn options to hide the welcome screen (#6262)
7c767ab 
### What
- Partially addresses: #6140

We still need to also tackle
#6263 since the place-holder UI
isn't great.

![image](https://github.com/rerun-io/rerun/assets/3312232/736a42fb-a29e-48e2-8316-9dc790f1e3ad)

### Details
Handling this via blueprint is awkward since the welcome screen
presentation happens without respect to any given blueprint, or in cases
when all the recordings and their blueprints have been closed.

I decided adding this as a spawn option makes the most sense, since this
is the context where someone knows how they are embedding Rerun in
another application.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6262?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6262?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6262)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
abey79 added a commit that referenced this issue May 10, 2024
@abey79
Improve the default UI when the welcome screen is hidden (#6287)
bc68940 
### What

Follow-up of #6262 to improve the default UI when the welcome screen is
disabled and no recordings are loaded.

- Fixes #6263

<img width="1522" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/ce7355e3-2aad-4171-9187-cda18df8aeaa">

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6287?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6287?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6287)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abey79 abey79

Labels
ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve the default UI when the welcome screen is hidden rerun-io/rerun
2 participants
@jleibs @abey79