List item: LabelContent should be able to have the exact same action button and behaviour as PropertyContent
#6203
Labels
ui
concerns graphical user interface
Comments
This was referenced May 2, 2024
abey79
added a commit
that referenced
this issue
May 3, 2024
…6184) ### What This PR deploys `list_item2` to the visualizer and overrides UI currently used for timeseries spaces views. Unsurprisingly, contact with the real world required some adjustments: - It's useful to be able to mix and match `LabelContent` and `PropertyContent`. The following changes were needed for that to look nice: - Both contents have now a configurable `min_desired_width`. - `LabelContent` now has a `always_show_buttons` option that perma-displays the buttons. This makes it easy to emulate `PropertyContent`'s action button. This could be improved: #6203 - Now the left column width is computed based on the total width actually allocated by `ListItem` (as opposed to `ui.max_rect()` as seen from `list_item_scope`). This is more correct when the list is in a horizontal scroll area and fixes related visual glitches. This PR also fixes the ShapeMarker editor UI, but required a workaround due to `ui.max_rect()` behaving weird when the ComboBox menu expends due to its contents. - Part of #6075 - Follow up to #6183 - Fixes #4984 - Fixes #6205 <img width="207" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/60f85e2e-cc67-48a5-8331-e943c246453b"> <br/> ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6184?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6184?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/6184) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This would make it easier to mix and match both types of content in the same lists. #6184 introduce some changes that makes this possible, but this should be improved.
This should probably be done combined with #6191
The text was updated successfully, but these errors were encountered: