Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heuristics for depth image size broken, causing arkit scenes to be unusable #6175

Closed
Wumpf opened this issue Apr 30, 2024 · 0 comments · Fixed by #6190
Closed

Heuristics for depth image size broken, causing arkit scenes to be unusable #6175

Wumpf opened this issue Apr 30, 2024 · 0 comments · Fixed by #6190
Labels
🦟 regression A thing that used to work in an earlier release
Milestone
0.16

Comments

@Wumpf
Copy link
Member

Wumpf commented Apr 30, 2024

Must have gone in very recently.

Can't see the mesh anymore because it's dwarfed by the depth cloud
image
@Wumpf Wumpf added the 🦟 regression A thing that used to work in an earlier release label Apr 30, 2024
@Wumpf Wumpf added this to the 0.16 milestone Apr 30, 2024
@Wumpf Wumpf mentioned this issue Apr 30, 2024
Merged
5 tasks
@github-actions github-actions bot mentioned this issue May 2, 2024
Merged
5 tasks
jleibs pushed a commit that referenced this issue May 2, 2024
@Wumpf @teh-cmc
Fix auto properties no longer being applied for legacy properties (`E…
0c14528 
…ntityProperties`) (#6190)

### What

* Fixes #6175

This regressed in #6164. Decided not to roll back things (which would
have been hard) but instead reimplement how these properties are passed
through and make their role more obvious.


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6190?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6190?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6190)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.

---------

Co-authored-by: Clement Rey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🦟 regression A thing that used to work in an earlier release
Projects
None yet
Milestone
0.16
Development

Successfully merging a pull request may close this issue.

Fix auto properties no longer being applied for legacy properties (EntityProperties) rerun-io/rerun
1 participant
@Wumpf