Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send currently opened app & recording ID to data-loaders #5350

Closed
teh-cmc opened this issue Feb 29, 2024 · 2 comments · Fixed by #7880
Closed

Send currently opened app & recording ID to data-loaders #5350

teh-cmc opened this issue Feb 29, 2024 · 2 comments · Fixed by #7880
Assignees
@teh-cmc
Labels
enhancement New feature or request 📺 re_viewer affects re_viewer itself user-request This is a pressing issue for one of our users

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Feb 29, 2024 •
edited
Loading

So they can decide to either append to the currently opened recording or create a new one when e.g. drag-n-dropping.

Probably want a special shortcut to switch the behavior when drag-n-dropping (e.g. hold shift to split into individual recordings), but that can come in a second iteration I think.
@teh-cmc teh-cmc added enhancement New feature or request 📺 re_viewer affects re_viewer itself labels Feb 29, 2024
@teh-cmc teh-cmc mentioned this issue Feb 29, 2024
Merged
8 tasks
teh-cmc added a commit that referenced this issue Feb 29, 2024
@teh-cmc
SDK DataLoaders 5: customizable (external) loaders for Rust (#5351)
9e3ffc2 
Adds new `RecommendedLoadSettings` that gets passed to all `DataLoader`s
-- builtin and external -- in order to customize their behaviors.

This includes:
- A recommended recording ID
- The ID of the currently opened recording in the viewer (not
implemented)
  - Related: #5350
- A recommended entity path prefix
- A recommended timepoint

```bash
cargo r -p rerun-loader-rust-file -- run_wasm/src/main.rs  --recording-id this-one --entity-path-prefix a/b/c  --time sim_time=1000 --time wall_time=1709204046 --sequence sim_frame=42 | rerun -
```

![image](https://github.com/rerun-io/rerun/assets/2910679/631d9798-c198-4e86-b6f8-32d0b849e7b2)


Checks:
- [x] external loader ran manually (`loader | rerun`)
- [x] external loader via rerun (`rerun xxx.rs`)
- [x] log_file with external loader (`log_file xxx.rs`)

---

Part of series of PR to expose configurable `DataLoader`s to our SDKs:
- #5327 
- #5328 
- #5330
- #5337
- #5351
- #5355
@teh-cmc teh-cmc changed the title Send currently opened recording ID to data-loaders Send currently opened app & recording ID to data-loaders Mar 4, 2024
@teh-cmc teh-cmc mentioned this issue Oct 19, 2024
Closed
@teh-cmc
Copy link
Member Author

teh-cmc commented Oct 22, 2024

I'm blocked on this for some docs/examples, let's see how hard that is.

@teh-cmc teh-cmc self-assigned this Oct 22, 2024
@teh-cmc teh-cmc added the user-request This is a pressing issue for one of our users label Oct 22, 2024
@emilk
Copy link
Member

emilk commented Oct 23, 2024

Probably want a special shortcut to switch the behavior when drag-n-dropping

Or depending on where in the viewer we drop (this has finally been unblocked in winit)

@teh-cmc teh-cmc mentioned this issue Oct 23, 2024
Merged
6 tasks
teh-cmc added a commit that referenced this issue Oct 24, 2024
@teh-cmc
Implement support for in-place drag-n-drop (#7880)
91e981a 
It is pretty tricky to get right (unsurprisingly) -- `StoreId`s and
`RecordingId`s and `SetStoreInfo`s are all pretty finicky constructs and
a lot can go wrong when loading arbitrarily things in place. But it
works pretty nicely overall!



https://github.com/user-attachments/assets/43f4e647-317a-47b5-a570-bee70716a2de

* Fixes #5350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teh-cmc teh-cmc

Labels
enhancement New feature or request 📺 re_viewer affects re_viewer itself user-request This is a pressing issue for one of our users
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement support for in-place drag-n-drop rerun-io/rerun
2 participants
@emilk @teh-cmc