New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context menu: add actions for `DataResults` #5299

Closed

abey79 opened this issue Feb 27, 2024 · 0 comments · Fixed by #5411

Assignees

Labels

ui

Member

abey79 commented Feb 27, 2024 •

edited

Loading

Actions:

Show/hide
Remove (-> add an exclusion in the query)
Add to new view (-> create a new space view and add this specific entity)

Blocked on:

Deprecate "groups" as a concept from the DataResultTree. #4441

Supersedes:

Add contextual menu to blueprint tree for common actions #4823

The text was updated successfully, but these errors were encountered:

abey79 added the ui label

abey79 self-assigned this

abey79 mentioned this issue

More context menu 4: create a new space view with selected entities #5411

Merged

5 tasks

abey79 closed this as completed in #5411

abey79 added a commit that referenced this issue


          More context menu 4: create a new space view with selected entities (#…

5eebbac

…5411)

### What

As the title says ☝🏻 

* Fixes #5299

Also adds a "no action available for this selection" notice that got
lost in #5392.

Makes it very easy to bump into:
- #5410


https://github.com/rerun-io/rerun/assets/49431240/d3bafbf4-3755-4f6f-b236-bd1d022b172f


#### Design decisions

- The origin of the newly created space view is set to "/"
- Alternative 1: set it to the clicked item. Strong reject: too arcane,
different results for the same multi-selection depending on which item
is actually clicked.
- Alternative 2: set it to the common ancestor of all selected entities.
Weak reject: less predictable, occasionally wrong (but works around some
visualisable issue we have with some space views).
- We show a list of suggested space view classes.
- The list is the *intersection* of the suggested classes for each of
the selected entities.
- For each entity, the suggested classes are determined based on the
*union* of suggested classes for the entity itself, *and for every
entity of its subtree*. This enables meaningful suggestion when
selecting a pure TreePrefix.
- The newly created space view is selected.

#### Known "phenomenons"

- 2D space views are rarely suggested, because of the origin is set to
"/" and that's outside of a pinhole transform.
  - TODO: issue number?
- Text Document and Text Log are often suggested for time series scalar,
because of the `Text` document.
- Tensor is recommended but will (sometime?) display nothing, e.g.
`structure_from_motion` -> `/camera/image`
- If enabled, Dataframe is always the top-most suggested Space View,
because of the lexicographic sorting.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5411/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5411/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5411/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5411)
- [Docs
preview](https://rerun.io/preview/979f2768f87bd3e72b45c80ffd319b56661f138e/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/979f2768f87bd3e72b45c80ffd319b56661f138e/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment