Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't receive larger WebSocket messages than 16MiB on native #5268

Closed
emilk opened this issue Feb 23, 2024 · 2 comments · Fixed by #5282
Closed

Can't receive larger WebSocket messages than 16MiB on native #5268

emilk opened this issue Feb 23, 2024 · 2 comments · Fixed by #5282
Assignees
Labels
🪳 bug Something isn't working 🏎️ Quick Issue Can be fixed in a few hours or less user-request This is a pressing issue for one of our users
Milestone

Comments

@emilk
Copy link
Member

emilk commented Feb 23, 2024

If a users tries to send a big chunk of that (e.g. a 10 mega-pixel RGBA image) then they might hit the default 16 MiB data frame limit in tungstenite:

https://docs.rs/tungstenite/latest/tungstenite/protocol/struct.WebSocketConfig.html#structfield.max_frame_size

We should increase this maximum by a lot, which will require changes to ewebsock

The error:

ERROR re_ws_comms::client] Connection error: read: Space limit exceeded: Message too long: 36008153 > 16777216

@emilk emilk added 🪳 bug Something isn't working 🏎️ Quick Issue Can be fixed in a few hours or less user-request This is a pressing issue for one of our users labels Feb 23, 2024
@emilk emilk added this to the 0.14 milestone Feb 23, 2024
@mpizenberg
Copy link
Contributor

Is this error likely to happen if I transfer a large mesh too? If increasing the max frame size is problematic, would it make sense to instead chunk the data sent into blocks smaller than the max frame size?

@mpizenberg
Copy link
Contributor

I can confirm that loading a medium size mesh crashes the viewer too. I have meshes of sizes up to 1GB approximately that I'd need to visualize eventually.

@emilk emilk self-assigned this Feb 26, 2024
Wumpf pushed a commit that referenced this issue Feb 26, 2024
* Closes #5268

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5282/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5282/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5282/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5282)
- [Docs
preview](https://rerun.io/preview/d30ec257f0553f728aaf28fd500aa2a8633bd4c3/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/d30ec257f0553f728aaf28fd500aa2a8633bd4c3/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🏎️ Quick Issue Can be fixed in a few hours or less user-request This is a pressing issue for one of our users
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants