Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spawn doesn't respect default_enabled(false) and RERUN=0 env var #5261

Closed
Wumpf opened this issue Feb 23, 2024 · 0 comments · Fixed by #5284
Closed

spawn doesn't respect default_enabled(false) and RERUN=0 env var #5261

Wumpf opened this issue Feb 23, 2024 · 0 comments · Fixed by #5284
Assignees
@Wumpf
Labels
🪳 bug Something isn't working 🪵 Log & send APIs Affects the user-facing API for all languages 🏎️ Quick Issue Can be fixed in a few hours or less
Milestone
0.14

Comments

@Wumpf
Copy link
Member

Wumpf commented Feb 23, 2024

Happens at least in Rust, likely in all SDKs.
@Wumpf Wumpf added 🪳 bug Something isn't working 🏎️ Quick Issue Can be fixed in a few hours or less 🪵 Log & send APIs Affects the user-facing API for all languages labels Feb 23, 2024
@emilk emilk added this to the 0.13.1 milestone Feb 23, 2024
@Wumpf Wumpf self-assigned this Feb 26, 2024
@Wumpf Wumpf mentioned this issue Feb 26, 2024
Merged
5 tasks
emilk pushed a commit that referenced this issue Feb 26, 2024
@Wumpf
Fix spawn starting the viewer even if logging is disabled (#5284)
76ded9b 
### What

* Fixes #5261

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5284/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5284/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5284/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5284)
- [Docs
preview](https://rerun.io/preview/c659f5a29d6a439bcf11756099e7e9338561774a/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/c659f5a29d6a439bcf11756099e7e9338561774a/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wumpf Wumpf

Labels
🪳 bug Something isn't working 🪵 Log & send APIs Affects the user-facing API for all languages 🏎️ Quick Issue Can be fixed in a few hours or less
Projects
None yet
Milestone
0.14
Development

Successfully merging a pull request may close this issue.

Fix spawn starting the viewer even if logging is disabled rerun-io/rerun
2 participants
@emilk @Wumpf