Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overwrite materials on Asset3D archetype - color tinting? #5253

Open
Wumpf opened this issue Feb 22, 2024 · 0 comments
Open

Allow overwrite materials on Asset3D archetype - color tinting? #5253

Wumpf opened this issue Feb 22, 2024 · 0 comments
Labels
enhancement New feature or request 🍏 primitives Relating to Rerun primitives

Comments

@Wumpf
Copy link
Member

Wumpf commented Feb 22, 2024

For very primitive Mesh formats like STL it seems to be common practice to provide some way of overwriting the material after the fact (since it's not possible to specify any material properties).
Having a way to change/affect the material of a logged Asset3D might be useful in general, so we should extend Asset3D accordingly and do a "best effort" material merging.

See https://wiki.ros.org/urdf/XML/link
URDF allows a material property with texture (unusable in STL due to lack of textures) and color (use as tint..?)

@Wumpf Wumpf added enhancement New feature or request 🍏 primitives Relating to Rerun primitives labels Feb 22, 2024
Wumpf added a commit that referenced this issue Oct 24, 2024
### What

The idea is to reproduce behavior of `Mesh3D` regarding color
modification on `Asset3D` :
- add `albedo_factor` 
- add `vertex_colors` as in `Mesh3D` 

In order to overwrite white default texture of `Asset3D` loaded from stl
and obj (gltf already have albedo_factor in file).

See: #5253 


![Screenshot from 2024-09-18
16-05-54](https://github.com/user-attachments/assets/3f9f396e-1549-4e88-a933-f6143bddf734)

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7458?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/7458?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/7458)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.

---------

Co-authored-by: Keyvan Goddard <[email protected]>
Co-authored-by: Andreas Reich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🍏 primitives Relating to Rerun primitives
Projects
None yet
Development

No branches or pull requests

1 participant