Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too large accumulated bounding box often leads to poor default camera view #5204

Closed
roym899 opened this issue Feb 15, 2024 · 1 comment · Fixed by #5209
Closed

Too large accumulated bounding box often leads to poor default camera view #5204

roym899 opened this issue Feb 15, 2024 · 1 comment · Fixed by #5209
Assignees
Labels
😤 annoying Something in the UI / SDK is annoying to use 🏎️ Quick Issue Can be fixed in a few hours or less

Comments

@roym899
Copy link
Collaborator

roym899 commented Feb 15, 2024

Describe the annoyance
A good example is the nuScenes one, where initially some data is logged close to the origin until the first transform for the car is logged; the subsequent data is then far away from the origin, and the accumulated bounding box will be way too big.

The too large bounding box makes double click behave quite unintuitively as it doesn't focus on what's currently in view, but rather resets the view to something pretty useless.

In my experience this is quite a common issue, that sometimes can be worked around by logging data in a specific order. However, that is not a nice solution.

Expected behavior
As discussed with @Wumpf it might be better to always focus on the current bounding box until the user has moved the camera.

Maybe adding an option to the Camera section for the 3D blueprint to allow switching between focusing on the accumulated and the current bounding box might be good to not make things worse in cases where the accumulated bounding box is more useful.

Related to #810.

@roym899 roym899 added 😤 annoying Something in the UI / SDK is annoying to use 👀 needs triage This issue needs to be triaged by the Rerun team labels Feb 15, 2024
@roym899
Copy link
Collaborator Author

roym899 commented Feb 15, 2024

Maybe worth noting that on repopulating the accumulated bounding box is reset (hence using the current bounding box for the camera view).

@roym899 roym899 changed the title Too large accumulated bounding box often leads to poor default camera Too large accumulated bounding box often leads to poor default camera view Feb 15, 2024
@Wumpf Wumpf added 🏎️ Quick Issue Can be fixed in a few hours or less and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Feb 15, 2024
@Wumpf Wumpf self-assigned this Feb 15, 2024
Wumpf added a commit that referenced this issue Feb 16, 2024
… view (double click it) (#5209)

### What

* Fixes #5204

Bit back and forth on this: Originally also wanted to track the
non-accumulated bounding box when data comes in, but for many scenes
this gets too awkward.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5209/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5209/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5209/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5209)
- [Docs
preview](https://rerun.io/preview/9a4526d29f61a77f2d9c1e87d61bb86b38392dff/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/9a4526d29f61a77f2d9c1e87d61bb86b38392dff/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😤 annoying Something in the UI / SDK is annoying to use 🏎️ Quick Issue Can be fixed in a few hours or less
Projects
None yet
2 participants