Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double clicking plot background selects the first series #5090

Closed
nikolausWest opened this issue Feb 7, 2024 · 0 comments · Fixed by #5096
Closed

Double clicking plot background selects the first series #5090

nikolausWest opened this issue Feb 7, 2024 · 0 comments · Fixed by #5096
Assignees
@jleibs
Labels
😤 annoying Something in the UI / SDK is annoying to use 👀 needs triage This issue needs to be triaged by the Rerun team ui concerns graphical user interface
Milestone
0.13

Comments

@nikolausWest
Copy link
Member

What: When double clicking the background of a time series plot to reset the view, it selects the first series.

Expected: Either don't change the selection or select the space view
@nikolausWest nikolausWest added ui concerns graphical user interface 😤 annoying Something in the UI / SDK is annoying to use 👀 needs triage This issue needs to be triaged by the Rerun team labels Feb 7, 2024
@nikolausWest nikolausWest added this to the 0.13 milestone Feb 7, 2024
@jleibs jleibs self-assigned this Feb 7, 2024
@jleibs jleibs mentioned this issue Feb 7, 2024
Merged
5 tasks
Wumpf pushed a commit that referenced this issue Feb 7, 2024
@jleibs
Improve the selection/hover behavior for plots (#5096)
70b3dd8 
### What
 - Resolves: #5090

Several changes to plots:
- When resetting the plot, don't trigger a selection. Previously if an
item ended up under the cursor **after** the reset, it would end up
selected.
- Additionally, when hovering/clicking the background of the plot,
process hover/selection accordingly.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5096/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5096/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5096/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5096)
- [Docs
preview](https://rerun.io/preview/fa4f6d378ee0bde0a4de2b6caa3866b763145b0c/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/fa4f6d378ee0bde0a4de2b6caa3866b763145b0c/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jleibs jleibs

Labels
😤 annoying Something in the UI / SDK is annoying to use 👀 needs triage This issue needs to be triaged by the Rerun team ui concerns graphical user interface
Projects
None yet
Milestone
0.13
Development

Successfully merging a pull request may close this issue.

Improve the selection/hover behavior for plots rerun-io/rerun
2 participants
@nikolausWest @jleibs