Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DepthMeter is ignored #5070

Closed
jleibs opened this issue Feb 6, 2024 · 3 comments
Closed

DepthMeter is ignored #5070

jleibs opened this issue Feb 6, 2024 · 3 comments
Assignees
@emilk
Labels
🪳 bug Something isn't working 🔺 re_renderer affects re_renderer itself
Milestone
0.13

Comments

@jleibs
Copy link
Member

jleibs commented Feb 6, 2024 •
edited
Loading

Describe the bug

The mesh no longer shows up.

To Reproduce
Go to: https://app.rerun.io/commit/b9cd458/?url=https://app.rerun.io/version/nightly/examples/arkit_scenes.rrd

Expected behavior
Should see the mesh

Screenshots
image

Backtrace

Desktop (please complete the following information):

  • OS: Ubuntu.
  • Reproduces on both Native and Web

Rerun version

Additional context
@jleibs jleibs added 🪳 bug Something isn't working 👀 needs triage This issue needs to be triaged by the Rerun team labels Feb 6, 2024
@jleibs jleibs added this to the 0.13 milestone Feb 6, 2024
@emilk emilk added 🔺 re_renderer affects re_renderer itself and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Feb 6, 2024
@emilk emilk self-assigned this Feb 6, 2024
@emilk
Copy link
Member

emilk commented Feb 6, 2024 •
edited
Loading

Actually, the mesh is there. You just have to zoom in (on the labels) a lot:

image

It is the depth point cloud that is extremely large.

The logging is done with rr.DepthImage(depth, meter=1000) but it ends up in the viewer with meter = 1.0.

@emilk emilk changed the title The mesh is no longer visible in arkit_scenes arkit_scenes depth point cloud is enormous Feb 6, 2024
@emilk emilk changed the title arkit_scenes depth point cloud is enormous DepthMeter is ignored Feb 6, 2024
@emilk emilk mentioned this issue Feb 6, 2024
Merged
5 tasks
@emilk
Copy link
Member

emilk commented Feb 6, 2024

The problem sits in SpaceViewBlueprint::on_frame_start. It fills in a per_system_entities which is empty.

Why? Because every single entity has zero visualizers according to the DataQueryResult from lookup_query_result.

I suspect this got broken in #5050

@jleibs
Copy link
Member Author

jleibs commented Feb 6, 2024

Confirmed, fixed by: #5068

@emilk emilk closed this as completed Feb 6, 2024
emilk added a commit that referenced this issue Feb 6, 2024
@emilk
Fix forever repaint of big scenes (#5071)
74d918d 
### What
* Closes #5018

When first loading a scene, before the user interacts, we want to center
the eye-camera on the scene, so each frame we call "interpolate to the
default eye". This should be fine, because we have an early-out if we're
already at target. However, the interpolation code had a rounding error
meaning we reached _very close_ to our goal, but not quite there. In
particular, in `arkit_scenes` it would lead to a forever repaint, since
the eye-camera would never reach its target, and so thus would require
more animation.

This manifested in `arkit_scenes` now due to another bug
(#5070) causing enormous point
clouds, making the rounding errors larger than usual.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5071/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5071/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5071/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5071)
- [Docs
preview](https://rerun.io/preview/d20d34685e6aaba1daf5c6417e1bb39d22448d40/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/d20d34685e6aaba1daf5c6417e1bb39d22448d40/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

Labels
🪳 bug Something isn't working 🔺 re_renderer affects re_renderer itself
Projects
None yet
Milestone
0.13
Development

No branches or pull requests
2 participants
@emilk @jleibs