Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store non-deterministically returns ComponentNotFound for new MarkerShape #5005

Closed
jleibs opened this issue Feb 1, 2024 · 2 comments · Fixed by #5007
Closed

Store non-deterministically returns ComponentNotFound for new MarkerShape #5005

jleibs opened this issue Feb 1, 2024 · 2 comments · Fixed by #5007
Assignees
@teh-cmc
Labels
🪳 bug Something isn't working ⛃ re_datastore affects the datastore itself
Milestone
0.13

Comments

@jleibs
Copy link
Member

jleibs commented Feb 1, 2024 •
edited
Loading

This specifically impacts #5004

Can repro using the branch (jleibs/point_markers) and the code:

import math

import rerun as rr

rr.init("rerun_example_scalar", spawn=True)

for step in range(0, 64):
    rr.set_time_sequence("step", step)
    rr.log("scalar/cos", rr.archetypes.Scalar(math.cos(step / 10.0)))
    rr.log("scalar/sin", rr.archetypes.Scalar(math.sin(step / 10.0)))

Sometimes everything works as expected:
image

But sometimes we get an error:

[2024-02-01T21:28:25Z ERROR re_viewport::system_execution] Error executing visualizer "SeriesPoint": Could not find component: rerun.components.MarkerShape

and the visualizer refuses to show the PointSeries:
image

Appears unrelated to the python logging since you can save an RRD file and reload it. Sometimes it will load properly, sometimes MarkerShape won't work.
@jleibs jleibs added 🪳 bug Something isn't working ⛃ re_datastore affects the datastore itself labels Feb 1, 2024
@jleibs jleibs added this to the 0.13 milestone Feb 1, 2024
@jleibs jleibs mentioned this issue Feb 1, 2024
Merged
4 tasks
@jleibs
Copy link
Member Author

jleibs commented Feb 1, 2024

This appears this is caching related as disabling primary_caching appears to avoid the issue.

@teh-cmc
Copy link
Member

teh-cmc commented Feb 2, 2024 •
edited
Loading

I wouldn't be surprised if that's another bug I introduced in the reentrancy patch... 😒 looking.

Nevermind, just a silly piece of error handling.

@teh-cmc teh-cmc self-assigned this Feb 2, 2024
@teh-cmc teh-cmc mentioned this issue Feb 2, 2024
Merged
4 tasks
teh-cmc added a commit that referenced this issue Feb 2, 2024
@teh-cmc
Primary cache: allow entirely missing optional component columns (#5007)
b234599 
The cache would return a `ComponentNotFound` error if the user queried
for an optional component that didn't exist at all (as in: we have never
even heard of that datatype until now).

This can be triggered with e.g. this:
```
import math

import rerun as rr

rr.init("rerun_example_scalar", spawn=True)

for step in range(0, 64):
    rr.set_time_sequence("step", step)
    rr.log("scalar/cos", rr.archetypes.Scalar(math.cos(step / 10.0)))
    rr.log("scalar/sin", rr.archetypes.Scalar(math.sin(step / 10.0)))
```

The visualizer would ask for `MarkerShape`, which is an optional
component that as far as the store and the cache are concerned is
completely made up at this point.

- Fixes #5005
jleibs added a commit that referenced this issue Feb 2, 2024
@jleibs @emilk
Introduce a new component for MarkerShape and use it in SeriesPoint (#…
afca28b 
…5004)

### What
 - Add new MarkerShape component
 - Register a component-editor for it
 - Use it in PointVisualizerSystem / TimeSeries space-view
 - Bump up the radius for the point visualizer system


![image](https://github.com/rerun-io/rerun/assets/3312232/c3f065f4-5bd8-4241-85b8-db4986b5b989)


TODO:
 - #5005


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/5004/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/5004/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/5004/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/5004)
- [Docs
preview](https://rerun.io/preview/d958ad44008ad21a5313a52985e397b0e04e4d74/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/d958ad44008ad21a5313a52985e397b0e04e4d74/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

---------

Co-authored-by: Emil Ernerfeldt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teh-cmc teh-cmc

Labels
🪳 bug Something isn't working ⛃ re_datastore affects the datastore itself
Projects
None yet
Milestone
0.13
Development

Successfully merging a pull request may close this issue.

Primary cache: allow entirely missing optional component columns rerun-io/rerun
2 participants
@teh-cmc @jleibs