New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style containers in the same way as unnamed space view #4966

Closed

abey79 opened this issue Jan 30, 2024 · 0 comments · Fixed by #4975

Assignees

Labels

ui

Milestone

Member

abey79 commented Jan 30, 2024 •

edited

Loading

After all, they are unnamed, until this:

Let user assign custom names to container #4967

abey79 added the ui label

abey79 mentioned this issue

Let user assign custom names to container #4967

Closed

abey79 self-assigned this

nikolausWest added this to the 0.13 milestone

abey79 mentioned this issue

Style container's label as unnamed #4975

Merged

4 tasks

abey79 closed this as completed in #4975

abey79 added a commit that referenced this issue


          Style container's label as unnamed (#4975)

a7356ca

### What

This PR styles the container label like unnamed space views in the
blueprint tree and the children list (container selection panel). It
also fixes the UI and behaviour of tiles tabs for container (which
typically appear when a tab container's direct child is also a
container).

* Fixes #4966


<img width="2168" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/833d9c56-e371-417a-8bdf-9ebf11a50c1e">


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4975/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4975/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4975/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4975)
- [Docs
preview](https://rerun.io/preview/62492dfe767dece952ea8c12e62269e42af6053d/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/62492dfe767dece952ea8c12e62269e42af6053d/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment