New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to select Scalar entity in TimeSeriesView #4952

Closed

Tracked by

jleibs opened this issue Jan 29, 2024 · 0 comments · Fixed by #4959

Closed

Tracked by

Ability to select Scalar entity in TimeSeriesView #4952

jleibs opened this issue Jan 29, 2024 · 0 comments · Fixed by #4959

Assignees

Labels

ui

Member

jleibs commented Jan 29, 2024

Selecting an entity currently requires using the blueprint tree. We should be able to directly click lines / points to select them.

jleibs added the ui label

jleibs assigned Wumpf

jleibs mentioned this issue

Tracking issue: timeseries space view #4813

Open

14 tasks

Wumpf mentioned this issue

Allow selection of entities directly in the plot space view #4959

Merged

4 tasks

Wumpf closed this as completed in #4959

Wumpf added a commit that referenced this issue


          Allow selection of entitites directly in the plot space view (#4959)

ffe8a10

### What

* depends on emilk/egui#3920
* Fixes #4952
* Closes #4828


Wires up the new plot item ids to our hover/selection mechanism.
Moved a utility method from item_ui to ViewerContext since I didn't want
to take a dependency on `re_data_ui` here (and this method had a todo
about being in the wrong spot anyways 😄 )



https://github.com/rerun-io/rerun/assets/1220815/1ef61a4f-7e13-4661-90c6-fa53ea008823



DRAFT: Uses unpublished egui version!


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4959/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4959/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4959/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4959)
- [Docs
preview](https://rerun.io/preview/f3f871cc9d2504b9c12a445787116a69af91f47f/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/f3f871cc9d2504b9c12a445787116a69af91f47f/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment