Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading data with RAYON_NUM_THREADS=1 does nothing #4938

Closed
teh-cmc opened this issue Jan 29, 2024 · 1 comment · Fixed by #4942
Closed

Loading data with RAYON_NUM_THREADS=1 does nothing #4938

teh-cmc opened this issue Jan 29, 2024 · 1 comment · Fixed by #4942
Assignees
Labels
🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself
Milestone

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Jan 29, 2024

This is true for both our latest release (0.12.1) and our latest main: RAYON_NUM_THREADS=1 rerun plots.rrd just starts a viewer and then does nothing.

There's no deadlock, the viewer is alive and well: it just doesn't load data.

Either this is a bug and it needs to be fixed, or there is some logical reason for the loading path to require at least two independent compute threads, in which case we need to either document that reason and prevent NUM_THREADS=1 or make sure to spawn a dedicated native thread where required.

Putting on high priority as this might hide something very very wrong.

@teh-cmc teh-cmc added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself labels Jan 29, 2024
@teh-cmc teh-cmc added this to the 0.13 milestone Jan 29, 2024
@teh-cmc
Copy link
Member Author

teh-cmc commented Jan 29, 2024

This is caused by external loaders, removing them all from my PATH fixes the issue -- something is blocking and/or waiting for another task on the compute threadpool?

@teh-cmc teh-cmc self-assigned this Jan 29, 2024
teh-cmc added a commit that referenced this issue Jan 29, 2024
Not quite sure what I was thinking when i wrote this 😒 

- Fixes #4938 
- Fixes #4939
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant