-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI argument for setting max number of viewer threads #4931
Comments
This will also be useful when profiling, because it is hard to get an overview of 16 threads in puffin. We should perhaps default to So perhaps the default of |
|
I still think we should expose it as a CLI argument (and ideally an argument to |
This might be a good time for a Right now I think we don't initialize the thread pool explicitly when called from Python (meaning rayon threads are unnamed) |
### What * Closes #4931 You can now control the number of threads in the rayon thread pool using `-j` or `--threads`. The default is `-2`, meaning two less threads than the number of cores. This is to leave some breathing room for other threads the viewer spawns, as well as the rest of the users system. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/5021/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/5021/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/5021/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/5021) - [Docs preview](https://rerun.io/preview/e2052e86d1395fc070e84bd8357ce56081959d87/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/e2052e86d1395fc070e84bd8357ce56081959d87/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Since we started parallelizing the viewer, it can end up hogging too much CPU such that it interferes with other running processes.
Add a CLI argument that sets the max number of threads used by the viewer.
The text was updated successfully, but these errors were encountered: