Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Live preview the effect of a blueprint tree drag-and-drop in progress in the viewport #4916

Open
Tracked by #3120
abey79 opened this issue Jan 26, 2024 · 0 comments
Open
Tracked by #3120

Live preview the effect of a blueprint tree drag-and-drop in progress in the viewport #4916

abey79 opened this issue Jan 26, 2024 · 0 comments
Labels
ui concerns graphical user interface

Comments

@abey79
Copy link
Member

abey79 commented Jan 26, 2024 •
edited
Loading

Possible avenues:

  • Live update the viewport, always showing the resulting view if the dragged payload were to be dropped at the current location.
  • Same, but we some delay after the still mouse pointer, to limit the visual flickering?
  • For entities: preview the edit in place in the query editor (might need to force select the destination item?)
  • For entities: preview the edit diff in some hover tooltip next to the mouse.
@abey79 abey79 mentioned this issue Jan 26, 2024
Open
30 tasks
@abey79 abey79 added the ui concerns graphical user interface label Jan 26, 2024
@abey79 abey79 changed the title Live preview the effect of the drop in progress in the viewport. Live preview the effect of a blueprint tree drag-and-drop in progress in the viewport Jan 26, 2024
@abey79 abey79 mentioned this issue Jan 26, 2024
Merged
4 tasks
abey79 added a commit that referenced this issue Jan 30, 2024
@abey79 @emilk
Add support for drag-and-drop in blueprint tree (#4910)
1762957 
### What

This PR adds support for drag-and-drop in the blueprint tree.

- Fixes #2652


https://github.com/rerun-io/rerun/assets/49431240/4d5f47ae-6d79-4ad0-a05d-b7eaaac18659


It has the following known limitations/future work:
- Only a single item may be dragged at a time. If multiple items are
selected when a drag starts, the selection is set to contain only the
dragged item.
  - #4887
- Only space view and containers may be dragged. The drag and drop
operations only operate on the view hierarchy (not the space view data).
- The root container has a special behaviour: it cannot be successfully
dragged, and nothing can be dragged before/after it. This is consistent
with it being the root container, but inconsistent with how the UI is
presented.
  - #4909
- Because of how Grid container work (they support "holes", and tend to
swap instead of reflow items when reordering), some drag operation have
additional order side effects within the destination (grid) container.
- #4916

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4910/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4910/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4910/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4910)
- [Docs
preview](https://rerun.io/preview/b4084fe32cd0466fe6acd4807a33545091c9e1ba/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/b4084fe32cd0466fe6acd4807a33545091c9e1ba/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

---------

Co-authored-by: Emil Ernerfeldt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abey79