Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primary cache: fix error log sometimes when scrolling out of bounds #4858

Closed
teh-cmc opened this issue Jan 18, 2024 · 0 comments · Fixed by #4892
Closed

Primary cache: fix error log sometimes when scrolling out of bounds #4858

teh-cmc opened this issue Jan 18, 2024 · 0 comments · Fixed by #4892
Assignees
@teh-cmc
Labels
😤 annoying Something in the UI / SDK is annoying to use 🪳 bug Something isn't working 🔍 re_query affects re_query itself

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Jan 18, 2024 •
edited
Loading

E.g.

 ERROR re_viewport::system_execution] Error executing visualizer "Points2D": Could not find primary component: rerun.components.Position2D

Likely because something somewhere is giving us empty data and we're caching it as such?
@teh-cmc teh-cmc added 🪳 bug Something isn't working 😤 annoying Something in the UI / SDK is annoying to use 🔍 re_query affects re_query itself labels Jan 18, 2024
@teh-cmc teh-cmc self-assigned this Jan 18, 2024
@teh-cmc teh-cmc mentioned this issue Jan 23, 2024
Merged
4 tasks
Wumpf pushed a commit that referenced this issue Jan 24, 2024
@teh-cmc
Primary cache: do not err on PrimaryNotFound (#4892)
2bc6431 
Ignore `PrimaryNotFound` errors on the cached entity_iterator path, the
same way the vanilla path does.

- Fixes #4858
- DNR: requires #4856

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4892/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4892/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4892/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4892)
- [Docs
preview](https://rerun.io/preview/bebd894b2f4fc299c9882b9529d24c760b68e0bd/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/bebd894b2f4fc299c9882b9529d24c760b68e0bd/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teh-cmc teh-cmc

Labels
😤 annoying Something in the UI / SDK is annoying to use 🪳 bug Something isn't working 🔍 re_query affects re_query itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Primary cache: do not err on PrimaryNotFound rerun-io/rerun
1 participant
@teh-cmc