Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primary cache: display per-component sizes in detailed stats #4857

Closed
teh-cmc opened this issue Jan 18, 2024 · 0 comments · Fixed by #4890
Closed

Primary cache: display per-component sizes in detailed stats #4857

teh-cmc opened this issue Jan 18, 2024 · 0 comments · Fixed by #4890
Assignees
@teh-cmc
Labels
🧑‍💻 dev experience developer experience (excluding CI) 🚀 performance Optimization, memory use, etc

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Jan 18, 2024

Now that SizeBytes has been made available through the erased version of FlatVecDeque, this is actually possible.
@teh-cmc teh-cmc added 🧑‍💻 dev experience developer experience (excluding CI) 🚀 performance Optimization, memory use, etc labels Jan 18, 2024
@teh-cmc teh-cmc self-assigned this Jan 18, 2024
@teh-cmc teh-cmc mentioned this issue Jan 23, 2024
Merged
4 tasks
@teh-cmc teh-cmc linked a pull request Jan 23, 2024 that will close this issue
Primary cache: per-component size statistics #4890
Merged
4 tasks
teh-cmc added a commit that referenced this issue Jan 25, 2024
@teh-cmc
Primary cache: per-component size statistics (#4890)
7fcdb1d 
Before:

![image](https://github.com/rerun-io/rerun/assets/2910679/bec3e40a-529c-443d-9803-9581bfc977da)

After:

![image](https://github.com/rerun-io/rerun/assets/2910679/b1507279-7ca3-4c43-b47d-12b88864fdbc)


- Fix #4857
- DNR: requires #4856

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4890/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4890/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4890/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4890)
- [Docs
preview](https://rerun.io/preview/06db01a65d711ec7ba802169845e3b79337a91af/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/06db01a65d711ec7ba802169845e3b79337a91af/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teh-cmc teh-cmc

Labels
🧑‍💻 dev experience developer experience (excluding CI) 🚀 performance Optimization, memory use, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Primary cache: per-component size statistics rerun-io/rerun
1 participant
@teh-cmc