Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primary cache: de-staticify cache globals #4815

Closed
teh-cmc opened this issue Jan 15, 2024 · 0 comments · Fixed by #4856
Closed

Primary cache: de-staticify cache globals #4815

teh-cmc opened this issue Jan 15, 2024 · 0 comments · Fixed by #4856
Labels
🔍 re_query affects re_query itself 🚜 refactor Change the code, not the functionality

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Jan 15, 2024

Make each primary cache live alongside its associated datastore rather than having all of them in the same big static global var.
@teh-cmc teh-cmc added 🔍 re_query affects re_query itself 🚜 refactor Change the code, not the functionality labels Jan 15, 2024
@teh-cmc teh-cmc changed the title Primary caching: de-staticify cache globals Primary cache: de-staticify cache globals Jan 16, 2024
@teh-cmc teh-cmc mentioned this issue Jan 18, 2024
Merged
4 tasks
teh-cmc added a commit that referenced this issue Jan 23, 2024
@teh-cmc
Primary caching 19 (final): de-statification (#4856)
4444217 
- Quick sanity pass over all the intermediary locks and refcounts to
make sure we don't hold anything for longer than we need.
- Get rid of all static globals and let the caches live with their
associated stores in `EntityDb`.
- `CacheKey` no longer requires a `StoreId`.

---

- Fixes #4815 

---

Part of the primary caching series of PR (index search, joins,
deserialization):
- #4592
- #4593
- #4659
- #4680 
- #4681
- #4698
- #4711
- #4712
- #4721 
- #4726 
- #4773
- #4784
- #4785
- #4793
- #4800
- #4851
- #4852
- #4853
- #4856
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🔍 re_query affects re_query itself 🚜 refactor Change the code, not the functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Primary caching 19 (final): de-staticify cache globals rerun-io/rerun
1 participant
@teh-cmc