Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show size of RRD in the example page #4724

Closed
jleibs opened this issue Jan 8, 2024 · 2 comments · Fixed by #4841
Closed

Show size of RRD in the example page #4724

jleibs opened this issue Jan 8, 2024 · 2 comments · Fixed by #4841
Assignees
@emilk
Labels
enhancement New feature or request examples Issues relating to the Rerun examples 🏎️ Quick Issue Can be fixed in a few hours or less

Comments

@jleibs
Copy link
Member

jleibs commented Jan 8, 2024

As some of the examples potentially become larger, it's helpful to give users a hint about how much data they are about to download. We should be able to compute the rrd sizes and include that information in the manifest file and show it somewhere in the example summary.
@jleibs jleibs added enhancement New feature or request examples Issues relating to the Rerun examples labels Jan 8, 2024
@jleibs jleibs changed the title Show size of RRD in the example apge Show size of RRD in the example page Jan 8, 2024
@emilk emilk added the 🏎️ Quick Issue Can be fixed in a few hours or less label Jan 9, 2024
@jprochazk
Copy link
Member

Right now the example manifest is built separately from the rrd files, and this would mean we'd have to always build both together. A solution that wouldn't require any changes to builds/CI would be to use a HEAD request to retrieve the size of each rrd file and listing that in the UI.

@emilk
Copy link
Member

emilk commented Jan 16, 2024

doing a HEAD to ask for the size sounds like the best solution to me

@emilk emilk self-assigned this Jan 17, 2024
@emilk emilk mentioned this issue Jan 17, 2024
Merged
4 tasks
emilk added a commit that referenced this issue Jan 17, 2024
@emilk
Show download sizes of in the example page (#4841)
8e4e232 
### What
* Closes #4724


![image](https://github.com/rerun-io/rerun/assets/1148717/623f1d47-5f5d-4597-b117-00763cdf151c)

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4841/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4841/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4841/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4841)
- [Docs
preview](https://rerun.io/preview/7bf9d8177bdcf7abf61948aa6e431254cccc613e/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/7bf9d8177bdcf7abf61948aa6e431254cccc613e/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

Labels
enhancement New feature or request examples Issues relating to the Rerun examples 🏎️ Quick Issue Can be fixed in a few hours or less
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show download sizes of in the example page rerun-io/rerun
3 participants
@emilk @jprochazk @jleibs