Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent hyphen/underscore convention in example arguments #4531

Closed
roym899 opened this issue Dec 14, 2023 · 0 comments · Fixed by #4543
Closed

Inconsistent hyphen/underscore convention in example arguments #4531

roym899 opened this issue Dec 14, 2023 · 0 comments · Fixed by #4543
Assignees
@roym899
Labels
😤 annoying Something in the UI / SDK is annoying to use examples Issues relating to the Rerun examples 🏎️ Quick Issue Can be fixed in a few hours or less

Comments

@roym899
Copy link
Collaborator

roym899 commented Dec 14, 2023

Describe the annoyance
See title. Probably best to use hyphens always.
@roym899 roym899 added 😤 annoying Something in the UI / SDK is annoying to use examples Issues relating to the Rerun examples 👀 needs triage This issue needs to be triaged by the Rerun team 🏎️ Quick Issue Can be fixed in a few hours or less labels Dec 14, 2023
@roym899 roym899 self-assigned this Dec 14, 2023
@roym899 roym899 mentioned this issue Dec 14, 2023
Merged
4 tasks
@roym899 roym899 removed the 👀 needs triage This issue needs to be triaged by the Rerun team label Dec 14, 2023
roym899 added a commit that referenced this issue Dec 15, 2023
@roym899
Use hyphen instead of underscore for example arguments (#4543)
e2c7c10 
### What

Replaces underscores in example arguments with hyphens.

Closes #4531. 

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4543/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4543/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4543/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4543)
- [Docs
preview](https://rerun.io/preview/df6c21a2063a91f265cd282e6c6d5005141d7d3b/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/df6c21a2063a91f265cd282e6c6d5005141d7d3b/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roym899 roym899

Labels
😤 annoying Something in the UI / SDK is annoying to use examples Issues relating to the Rerun examples 🏎️ Quick Issue Can be fixed in a few hours or less
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use hyphen instead of underscore for example arguments rerun-io/rerun
1 participant
@roym899