Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a verbosity specific to the Selection Panel when a single item is selected #4375

Closed
abey79 opened this issue Nov 28, 2023 · 0 comments · Fixed by #4416
Closed

Add a verbosity specific to the Selection Panel when a single item is selected #4375

abey79 opened this issue Nov 28, 2023 · 0 comments · Fixed by #4416
Labels
enhancement New feature or request ui concerns graphical user interface

Comments

@abey79
Copy link
Member

abey79 commented Nov 28, 2023

#4370 introduce a fix to improve the UI components. In particular, it introduces a special case for when a single item is selected. In this case, the table should use an unrestricted span, and leave the Selection Panel's own ScrollArea deal with the scrolling. Since most of the time at most a single item is selected, this special case makes sense and improves the UX.

This should be generalised to other types of components, in particular AnnotationContext and Text components. To make that easier, I propose the following:

  • Rename UiVerbosity::All to UiVerbosity::SelectionPanel, to clarify the purpose of this verbosity level.
  • Add a new UiVerbosity::MultiSelectionPanel, to account for the case were multiple items are selected (and thus vertical space should be used sparingly by each item).

Making this distinction will help clean the fix from #4370 and roll that fix in other places.
@abey79 abey79 added 🪳 bug Something isn't working 👀 needs triage This issue needs to be triaged by the Rerun team labels Nov 28, 2023
@abey79 abey79 changed the title Add a verbosity specific to the Selection Panel when a single item is selcted Add a verbosity specific to the Selection Panel when a single item is selected Nov 28, 2023
@abey79 abey79 added enhancement New feature or request ui concerns graphical user interface and removed 🪳 bug Something isn't working 👀 needs triage This issue needs to be triaged by the Rerun team labels Nov 28, 2023
@abey79 abey79 mentioned this issue Nov 28, 2023
Merged
4 tasks
abey79 added a commit that referenced this issue Dec 1, 2023
@abey79
Add a new UI verbosity level to distiguish between single- and multi-…
9446e99 
…selection in the Selection Panel

Also:
- adjust `DataUi` impls accordingly
- add a script to log very long `AnnotationContext` for UI test purposes

TODO:
- [ ] update annotation context UI to use collapsible header

Fixes #4375
@abey79 abey79 mentioned this issue Dec 1, 2023
Merged
4 tasks
abey79 added a commit that referenced this issue Dec 6, 2023
@abey79 @emilk
Improve the Selection Panel UI for components when a single item is s…
9ad5a0d 
…elected (#4416)

### What

This PR:
- adds a new UI verbosity level to distinguish between single- and
multi-selection in the Selection Panel;
- adjusts `DataUi` impls accordingly;
- update the UI of for `AnnotationContext` to use collapsible headers
instead of inner scroll areas (there can be *many* tables for one
instance, so inner scroll bars are really annoying);
- adds a script to log very long `AnnotationContext` for UI test
purposes.


* Is affected by (and doesn't fix):
#4367
* Follow-up to #4370
* Fixes #4375

### Screenshot

New collapsible-header-based UI for annotation context:


https://github.com/rerun-io/rerun/assets/49431240/435566a0-420b-48d7-8ea4-026d02d903a2

Also fix this spurious separator (and the related sizing issue) at the
top of the hover box:

<img width="662" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/077a3af4-2a5d-423a-8609-46bbc4f66221">


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
  * Full build: [app.rerun.io](https://app.rerun.io/pr/4416/index.html)
* Partial build:
[app.rerun.io](https://app.rerun.io/pr/4416/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
- Useful for quick testing when changes do not affect examples in any
way
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4416)
- [Docs
preview](https://rerun.io/preview/83f1bdcdcd055dd46658343a44f9ae7022c64f45/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/83f1bdcdcd055dd46658343a44f9ae7022c64f45/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

---------

Co-authored-by: Emil Ernerfeldt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve the Selection Panel UI for components when a single item is selected rerun-io/rerun
1 participant
@abey79