Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose C++ include path on cmake script #4195

Closed
Wumpf opened this issue Nov 10, 2023 · 0 comments · Fixed by #4313
Closed

Expose C++ include path on cmake script #4195

Wumpf opened this issue Nov 10, 2023 · 0 comments · Fixed by #4313
Labels
🌊 C++ API C/C++ API specific 🏎️ Quick Issue Can be fixed in a few hours or less user-request This is a pressing issue for one of our users
Milestone
0.11

Comments

@Wumpf
Copy link
Member

Wumpf commented Nov 10, 2023

Can be useful for some kinds of workarounds in CMake land.
Add it to the list of exposed variables here as well https://www.rerun.io/docs/reference/cpp-sdk-cmake
@Wumpf Wumpf added 🏎️ Quick Issue Can be fixed in a few hours or less user-request This is a pressing issue for one of our users 🌊 C++ API C/C++ API specific labels Nov 10, 2023
@Wumpf Wumpf added this to the 0.11 C++ polish milestone Nov 13, 2023
@emilk emilk removed this from the 0.11 milestone Nov 21, 2023
@Wumpf Wumpf added this to the 0.11 milestone Nov 21, 2023
@Wumpf Wumpf mentioned this issue Nov 23, 2023
Merged
4 tasks
Wumpf added a commit that referenced this issue Nov 24, 2023
@Wumpf
Expose Rerun source/include dir in CMakeLists.txt (`RERUN_CPP_SOURCE_…
d5153cb 
…DIR`) (#4313)

### What

* Fixes #4195

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4313) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4313)
- [Docs
preview](https://rerun.io/preview/0ce2671010a22af30ab79746401b352ee0726ab4/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/0ce2671010a22af30ab79746401b352ee0726ab4/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🌊 C++ API C/C++ API specific 🏎️ Quick Issue Can be fixed in a few hours or less user-request This is a pressing issue for one of our users
Projects
None yet
Milestone
0.11
Development

Successfully merging a pull request may close this issue.

Expose Rerun source/include dir in CMakeLists.txt (RERUN_CPP_SOURCE_DIR) rerun-io/rerun
2 participants
@emilk @Wumpf