New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++ don't leak headers from _ext impls into public headers #3991

Closed

Wumpf opened this issue Oct 24, 2023 · 0 comments · Fixed by #4132

Assignees

Labels

🪳 bug 🌊 C++ API codegen/idl

Milestone

Member

Wumpf commented Oct 24, 2023

Most notoriously, Asset3D leaks and into rerun.hpp which is quite heavy!

Wumpf added 🪳 bug codegen/idl 🌊 C++ API labels

Wumpf added this to the 0.11 C++ polish milestone

Wumpf self-assigned this

Wumpf mentioned this issue

Fix unnecessary includes in code generated headers #4132

Merged

4 tasks

Wumpf closed this as completed in #4132

Wumpf added a commit that referenced this issue


          Fix unnecessary includes in code generated headers (#4132)

### What

* Fixes #3991
* Allow several _ext -> header copy blocks
* no longer automatically add all includes from _ext file to header
* detect includes in copy to header blocks and add them to the header
list
* rename `util.hpp` to `warning_macros.hpp`
* change copy-to-codegen markers to an xml like syntax, shortening it a
bit and making it easier to read

Oh and every _ext file I touched a bit more I cleaned up to use a less
autocomplete friendly but easier to understand way of handling the
extension code. Let's prefer this going forward (there's no functional
difference though).

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4132) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4132)
- [Docs
preview](https://rerun.io/preview/2799f8838b5920d4343011d09b6a75ce47666355/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/2799f8838b5920d4343011d09b6a75ce47666355/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)

---------

Co-authored-by: Jeremy Leibs <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment