New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Camera scene part should not be a part of 2D views #3806

Closed

jleibs opened this issue Oct 11, 2023 · 0 comments · Fixed by #3815

Labels

🪳 bug

Milestone

Member

jleibs commented Oct 11, 2023

Can't come up with any scenarios where this is the right behavior.

Related "pinhole_image_plane_distance" should not be visible and should have no impact on 2D views.

jleibs added the 🪳 bug label

jleibs added this to the 0.9.1 milestone

jleibs mentioned this issue

Never include the pinhole / camera part in a 2D space view #3815

Merged

4 tasks

jleibs closed this as completed in #3815

jleibs added a commit that referenced this issue


          Never include the pinhole / camera part in a 2D space view (#3815)

7d79cbe

### What
Resolves: #3806

Repro:
```
import numpy as np
import rerun as rr

rr.init("rerun_example_pinhole", spawn=True)
rng = np.random.default_rng(12345)

image = rng.uniform(0, 255, size=[3, 3, 3])
rr.log("world/image", rr.Image(image))
import time
time.sleep(3)
rr.log("world/image", rr.Pinhole(focal_length=3, width=3, height=3))
```

Before:

![image](https://github.com/rerun-io/rerun/assets/3312232/36bde4ae-6a67-47b4-b7e3-98df9187ed89)

After:

![image](https://github.com/rerun-io/rerun/assets/3312232/7fc37163-fdeb-4121-9b67-c6a15a613e86)

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3815) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/3815)
- [Docs
preview](https://rerun.io/preview/f5020bc739982f843f6af085309dbcce498db323/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/f5020bc739982f843f6af085309dbcce498db323/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment