Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility #3731

Open
emilk opened this issue Oct 7, 2023 · 2 comments
Open

Accessibility #3731

emilk opened this issue Oct 7, 2023 · 2 comments
Labels
enhancement New feature or request 🎄 tracking issue issue that tracks a bunch of subissues

Comments

@emilk
Copy link
Member

emilk commented Oct 7, 2023

We should strive to have some accessibility support in Rerun. The first and simplest step is turning on the AccessKit feature of eframe.

I have no idea of how do to proper accessibility for 3D data though.
@emilk emilk added enhancement New feature or request 🎄 tracking issue issue that tracks a bunch of subissues labels Oct 7, 2023
emilk added a commit that referenced this issue Oct 7, 2023
@emilk
Turn on AccessKit (accessibility)
8735326 
Part of #3731
@emilk emilk mentioned this issue Oct 7, 2023
Merged
4 tasks
emilk added a commit that referenced this issue Oct 9, 2023
@emilk
Turn on AccessKit accessibility integration (#3732)
37d14f0 
* Part of #3731

See [`AccessKit`](https://github.com/AccessKit/accesskit) for more.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3732) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/3732)
- [Docs
preview](https://rerun.io/preview/87353267113804323ccbd12ab5f1076c334b8604/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/87353267113804323ccbd12ab5f1076c334b8604/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
@abey79 abey79 added this to the 0.9.1 milestone Oct 9, 2023
@jleibs jleibs removed this from the 0.9.1 milestone Oct 9, 2023
@lunixbochs
Copy link

Accessibility Inspector only sees an application's window(s) if the app is run from a proper app bundle, as opposed to just running an executable from Terminal

I'm using rerun-sdk from Python. Accessibility Inspector was still unhappy until I made a skeleton app like this:

mkdir -p rerun.app/Contents/MacOS
cp ~/Library/Python/3.9/bin/rerun rerun.app/Contents/MacOS

After this, I was able to select buttons in rerun with Accessibility Inspector and see the tree.

I'll note the accessibility performance is much worse than I'd expect. Rechecking with Talon (which also uses egui with accesskit), I see the same laggy response. Not sure what's up there but it should probably go upstream to egui or accesskit. Basically hovering over a UI element with Accessibility Inspector has around a 1 second lag before it's highlighted, while another app like Safari highlights elements immediately.

@emilk
Copy link
Member Author

emilk commented Oct 13, 2023

Thanks for investigating this. That latency is very bad 😱!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request 🎄 tracking issue issue that tracks a bunch of subissues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lunixbochs @emilk @jleibs @abey79