Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segmentation Images should handle non-integer types in the viewer #3609

Closed
jleibs opened this issue Oct 2, 2023 · 0 comments · Fixed by #4585
Closed

Segmentation Images should handle non-integer types in the viewer #3609

jleibs opened this issue Oct 2, 2023 · 0 comments · Fixed by #4585
Labels
enhancement New feature or request 📺 re_viewer affects re_viewer itself

Comments

@jleibs
Copy link
Member

jleibs commented Oct 2, 2023

In #3608 we made it so that segmentation images are coerced to u16

However, this violates our policy of not modifying user data. Instead we should pass through data un-modified and handle it in the viewer.
@jleibs jleibs added enhancement New feature or request 📺 re_viewer affects re_viewer itself labels Oct 2, 2023
@jleibs jleibs mentioned this issue Oct 2, 2023
Closed
emilk added a commit that referenced this issue Oct 3, 2023
@emilk
Add TODO(#3609)
adaf59b
emilk added a commit that referenced this issue Oct 3, 2023
@emilk
Add TODO(#3609)
29cc0b0
@abey79 abey79 added this to the 0.9.1 milestone Oct 9, 2023
@jleibs jleibs removed this from the 0.9.1 milestone Oct 9, 2023
@jleibs jleibs mentioned this issue Dec 19, 2023
Merged
4 tasks
jleibs added a commit that referenced this issue Dec 20, 2023
@jleibs
Make it possible to log segmentation images directly as floats (#4585)
42bc02d 
### What
- Resolves: #3609

This appears to have already worked and was just being prevented by
obsolete checks. Also we weren't doing the user-space conversions in C++
or Rust anyways.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4585/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4585/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4585/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4585)
- [Docs
preview](https://rerun.io/preview/312d196768a5d04efc92e07fca391f53c141b0b4/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/312d196768a5d04efc92e07fca391f53c141b0b4/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make it possible to log segmentation images directly as floats rerun-io/rerun
2 participants
@jleibs @abey79