Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of archetype queries at timepoints before the archetype is logged #3320

Closed
jleibs opened this issue Sep 13, 2023 · 1 comment · Fixed by #3321 or #6036
Closed

Improve handling of archetype queries at timepoints before the archetype is logged #3320

jleibs opened this issue Sep 13, 2023 · 1 comment · Fixed by #3321 or #6036
Assignees
Labels
⛃ re_datastore affects the datastore itself

Comments

@jleibs
Copy link
Member

jleibs commented Sep 13, 2023

Currently when we query an archetype at a time before the archetype has been logged, we end up getting a PrimaryNotFound error. This means that every view-part-system does something like:

        match query_archetype_with_history::<A, N>(...) {
            Ok(_) | Err(QueryError::PrimaryNotFound(_)) => {}
            Err(err) => {
                re_log::error_once!("Unexpected error querying {ent_path:?}: {err}");
            }
        }

New systems sometimes forget to do this, leading to spurious warning pop-ups.

If the component exists but not at that time we should indicate this condition by returning an empty list rather than a None.

@jleibs jleibs added the ⛃ re_datastore affects the datastore itself label Sep 13, 2023
emilk pushed a commit that referenced this issue Sep 14, 2023
…ng TextLogs (#3321)

### What
Specifies the indicator component int he TextDocumentSystem to avoid
creating the view when we aren't loggined TextDocuments.

Also handles the case of PrimaryComponentNotFound is the way the other
views do until we resolve #3320

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3321) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/3321)
- [Docs
preview](https://rerun.io/preview/1b5002ff0195065dd12728b693321c4b7481e96e/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/1b5002ff0195065dd12728b693321c4b7481e96e/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
@teh-cmc teh-cmc reopened this Sep 14, 2023
@teh-cmc
Copy link
Member

teh-cmc commented Sep 14, 2023

Closed by mistake because a PR mentioned the word "resolve" and this issue number in the same sentence 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⛃ re_datastore affects the datastore itself
Projects
None yet
2 participants