Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mint conversions for basic math datatypes #3292

Closed
Wumpf opened this issue Sep 12, 2023 · 0 comments · Fixed by #4753
Closed

Add mint conversions for basic math datatypes #3292

Wumpf opened this issue Sep 12, 2023 · 0 comments · Fixed by #4753
Assignees
@Wumpf
Labels
🍏 primitives Relating to Rerun primitives 🦀 Rust API Rust logging API

Comments

@Wumpf
Copy link
Member

Wumpf commented Sep 12, 2023 •
edited
Loading

mint
For easy conversion/interop with other math libraries

Originally posted by @emilk in #3282 (comment)
@Wumpf Wumpf added 🦀 Rust API Rust logging API 🍏 primitives Relating to Rerun primitives labels Sep 12, 2023
@Wumpf Wumpf changed the title Add [mint](this: https://crates.io/crates/mint) conversions for basic math datatypes Add [mint](https://crates.io/crates/mint) conversions for basic math datatypes Sep 12, 2023
@Wumpf Wumpf changed the title Add [mint](https://crates.io/crates/mint) conversions for basic math datatypes Add mint conversions for basic math datatypes Sep 12, 2023
@Wumpf Wumpf mentioned this issue Sep 12, 2023
Merged
9 tasks
@abey79 abey79 added this to the 0.9.1 milestone Oct 9, 2023
@jleibs jleibs removed this from the 0.9.1 milestone Oct 9, 2023
@Wumpf Wumpf self-assigned this Jan 9, 2024
This was referenced Jan 9, 2024
Closed
Merged
Wumpf added a commit that referenced this issue Jan 9, 2024
@Wumpf
Add math type conversions to mint types (#4753)
2f27d91 
### What

* Fixes #3292

Also fixes `Vec4D::w()` returning z instead!

Adds missing extensions to Mat4.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4753/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4753/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4753/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4753)
- [Docs
preview](https://rerun.io/preview/82e8f1caab378afe4fb99032e10eaf7d59b28c95/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/82e8f1caab378afe4fb99032e10eaf7d59b28c95/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wumpf Wumpf

Labels
🍏 primitives Relating to Rerun primitives 🦀 Rust API Rust logging API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add integration with the mint crate rerun-io/rerun
3 participants
@Wumpf @jleibs @abey79