Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The hover previews on events in the Streams View flicker and block #3154

Closed
nikolausWest opened this issue Aug 30, 2023 · 6 comments · Fixed by #3171
Closed

The hover previews on events in the Streams View flicker and block #3154

nikolausWest opened this issue Aug 30, 2023 · 6 comments · Fixed by #3171
Assignees
Labels
😤 annoying Something in the UI / SDK is annoying to use 🏎️ Quick Issue Can be fixed in a few hours or less ui concerns graphical user interface

Comments

@nikolausWest
Copy link
Member

See video

streams.hover.preview.mp4

As you hover events in the streams view, the preview data UI flickers in and out and covers way too much of the UI. THe effect is quite jarring

How to reproduce:

pip install --pre -f https://build.rerun.io/commit/d7de7f9/wheels --upgrade rerun-sdk.  # Latest build as of Aug 30th 09.20 CET
python -m rerun_demo
@nikolausWest nikolausWest added ui concerns graphical user interface 😤 annoying Something in the UI / SDK is annoying to use labels Aug 30, 2023
@emilk
Copy link
Member

emilk commented Aug 30, 2023

Let's make sure we use UiVerbosity::Reduced for these, and if we are, make sure UiVerbosity::Reduced is smaller for this example

@emilk emilk added the 🏎️ Quick Issue Can be fixed in a few hours or less label Aug 30, 2023
@abey79
Copy link
Member

abey79 commented Aug 31, 2023

#3171 should fix the invasive tooltips.

It will not fix the flickering though, which is due to the mouse moving over a bunch of datapoints which are all separated by 2-3 pixels. I'm leaning towards "works as intended".

@nikolausWest
Copy link
Member Author

It will not fix the flickering though, which is due to the mouse moving over a bunch of datapoints which are all separated by 2-3 pixels. I'm leaning towards "works as intended".

Once the oversized tooltips are fixed, it might alleviate the problem. If it doesn't, we could consider waiting a little before showing the tooltip. At the same time that will affect the feeling of snappiness. Feels like @martenbjork kind of territory. Either way, happy to hold off on solving that for now if #3171 has a big enough effect

@abey79
Copy link
Member

abey79 commented Sep 1, 2023

Sounds good. I'm not sure about the actual psychological impact, but #3171 definitely has reduced tooltip size rather drastically.

@martenbjork
Copy link
Contributor

Shouldn't the tooltip work harder to get out of the way? Right now, it often covers the cursor, even though there is more space above the cursor where it could go. Here's my reference implementation: https://7e94j1.csb.app/ What do you think about this behavior?

Desktop - 1

abey79 added a commit that referenced this issue Sep 1, 2023
### What

Limit the size of component tooltips with `UiVerbosity::Reduced`

Fixes #3154

<img width="227" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/b0bde6b0-52ba-4d9b-9f4f-e709638de983">


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3171) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/3171)
- [Docs
preview](https://rerun.io/preview/35244cb0963af9643740613271415a8b7d4f4475/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/35244cb0963af9643740613271415a8b7d4f4475/examples)
<!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)

---------

Co-authored-by: Emil Ernerfeldt <[email protected]>
@abey79
Copy link
Member

abey79 commented Sep 1, 2023

I opened #3187 to cover the tooltip behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😤 annoying Something in the UI / SDK is annoying to use 🏎️ Quick Issue Can be fixed in a few hours or less ui concerns graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants