Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expanding streams view doesn't play nicely with other parts of the UI #3152

Closed
Tracked by #3150
nikolausWest opened this issue Aug 30, 2023 · 4 comments · Fixed by #3169
Closed
Tracked by #3150

Expanding streams view doesn't play nicely with other parts of the UI #3152

nikolausWest opened this issue Aug 30, 2023 · 4 comments · Fixed by #3169
Assignees
@abey79
Labels
🪳 bug Something isn't working 🏎️ Quick Issue Can be fixed in a few hours or less ui concerns graphical user interface
Milestone
0.9 - Codegen, Ty...

Comments

@nikolausWest
Copy link
Member

See video

streams.view.sizes.mp4

How to reproduce:

pip install --pre -f https://build.rerun.io/commit/d7de7f9/wheels --upgrade rerun-sdk.  # Latest build as of Aug 30th 09.20 CET
python -m rerun_demo
@nikolausWest nikolausWest added 🪳 bug Something isn't working ui concerns graphical user interface labels Aug 30, 2023
@abey79
Copy link
Member

abey79 commented Aug 30, 2023

Tagging with 0.9 in case this is a quick fix.

@abey79 abey79 mentioned this issue Aug 30, 2023
Closed
4 tasks
@emilk
Copy link
Member

emilk commented Aug 30, 2023

Let's add a max size to it that leaves at least 25% or 200 pixels level on the screen, or something like that.

@nikolausWest
Copy link
Member Author

Let's add a max size to it that leaves at least 25% or 200 pixels level on the screen, or something like that.

If we can avoid a max size that would be nice. It's actually really useful to show just the streams view to explain what's going on in the underlying data model

@emilk emilk added the 🏎️ Quick Issue Can be fixed in a few hours or less label Aug 30, 2023
@abey79
Copy link
Member

abey79 commented Aug 31, 2023 •
edited
Loading

Looking into it, it introduce some complexity in quite a few widgets. My proposal:

  1. Implement @emilk's suggestion of enforcing a limit at 200px or something.
  2. Build (or use if it exists already) a "snapping" resizing system for panel: resizing close to max height should "snap" to using the full height (ie. in that case we dont even draw the viewport/side panels/etc.). Likewise, it would be nice that resizing the time panel all the way down would "snap" to its collapsed state (which would have the added benefit of freeing the top-right button to actually hide the timeline, which can't be done currently).

I'll open a PR for (1) and an issue for (2).

Edit:

@abey79 abey79 mentioned this issue Aug 31, 2023
Merged
3 tasks
emilk pushed a commit that referenced this issue Sep 1, 2023
@abey79
Clamp time panel height to avoid visual glitches (#3169)
4718642 
### What

Fixes #3152

*Note to reviewer*: I had to resort to some semi-hack to measure the
height of "everything above the viewport", i.e. windows title bar vs.
heading banner on web (which are significantly different). That's the
`screen_header_height` variable. Open to suggestion to make that
cleaner.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] ~~I've included a screenshot or gif (if applicable)~~
* [x] ~~I have tested [demo.rerun.io](https://demo.rerun.io/pr/3169) (if
applicable)~~ PR demo somehow failed, here is the [demo for commit
8fb79bf](https://demo.rerun.io/commit/8fb79bf/examples/structure_from_motion/)

- [PR Build Summary](https://build.rerun.io/pr/3169)
- [Docs
preview](https://rerun.io/preview/d110bc598c8fd1644d1ad658b45ece7d9c752df0/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/d110bc598c8fd1644d1ad658b45ece7d9c752df0/examples)
<!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abey79 abey79

Labels
🪳 bug Something isn't working 🏎️ Quick Issue Can be fixed in a few hours or less ui concerns graphical user interface
Projects
None yet
Milestone
0.9 - Codegen, Type Oriented Api
Development

Successfully merging a pull request may close this issue.

Clamp time panel height to avoid visual glitches rerun-io/rerun
3 participants
@emilk @nikolausWest @abey79