Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewer constantly refreshes without user input #2897

Closed
abey79 opened this issue Aug 2, 2023 · 1 comment · Fixed by #2900
Closed

Viewer constantly refreshes without user input #2897

abey79 opened this issue Aug 2, 2023 · 1 comment · Fixed by #2900
Labels
🪳 bug Something isn't working 🦟 regression A thing that used to work in an earlier release
Milestone
0.9 - Codegen, Ty...

Comments

@abey79
Copy link
Member

abey79 commented Aug 2, 2023

This is a recently introduced bug where frames are constantly requested.

Repro (e.g):

cargo r -p objectron
@abey79 abey79 added the 🪳 bug Something isn't working label Aug 2, 2023
@abey79 abey79 added this to the 0.9 milestone Aug 2, 2023
@teh-cmc teh-cmc added the 🦟 regression A thing that used to work in an earlier release label Aug 2, 2023
@abey79
Copy link
Member Author

abey79 commented Aug 2, 2023 •
edited
Loading

git bisect says its aa1822d (#2839)

@Wumpf Wumpf mentioned this issue Aug 2, 2023
Merged
3 tasks
Wumpf added a commit that referenced this issue Aug 3, 2023
@Wumpf
Fix always redrawing in the presence of a 3D space view (#2900)
f453f37 
* Fixes #2897

### What

Fix regression introduced in #2839
This landed in 0.8. Candidate for potential 0.8.1 release if we decide
to do one.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2900) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2900)
- [Docs
preview](https://rerun.io/preview/pr%3Aandreas%2Ffix-redraw/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Aandreas%2Ffix-redraw/examples)
emilk pushed a commit that referenced this issue Aug 17, 2023
@Wumpf @emilk
Fix always redrawing in the presence of a 3D space view (#2900)
683a2a9 
* Fixes #2897

### What

Fix regression introduced in #2839
This landed in 0.8. Candidate for potential 0.8.1 release if we decide
to do one.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2900) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2900)
- [Docs
preview](https://rerun.io/preview/pr%3Aandreas%2Ffix-redraw/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Aandreas%2Ffix-redraw/examples)
emilk pushed a commit that referenced this issue Aug 17, 2023
@Wumpf @emilk
Fix always redrawing in the presence of a 3D space view (#2900)
b65afaa 
* Fixes #2897

### What

Fix regression introduced in #2839
This landed in 0.8. Candidate for potential 0.8.1 release if we decide
to do one.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2900) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2900)
- [Docs
preview](https://rerun.io/preview/pr%3Aandreas%2Ffix-redraw/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Aandreas%2Ffix-redraw/examples)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🪳 bug Something isn't working 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Milestone
0.9 - Codegen, Type Oriented Api
Development

Successfully merging a pull request may close this issue.

Fix always redrawing in the presence of a 3D space view rerun-io/rerun
2 participants
@teh-cmc @abey79