Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI point size is wrong when zooming in 2D image #2758

Closed
Tracked by #2779
jleibs opened this issue Jul 19, 2023 · 4 comments · Fixed by #2805
Closed
Tracked by #2779

UI point size is wrong when zooming in 2D image #2758

jleibs opened this issue Jul 19, 2023 · 4 comments · Fixed by #2805
Assignees
@Wumpf
Labels
🪳 bug Something isn't working 🏎️ Quick Issue Can be fixed in a few hours or less ui concerns graphical user interface
Milestone
0.8

Comments

@jleibs
Copy link
Member

jleibs commented Jul 19, 2023

Run colmap, in both the 3D and the 2D view set the UI points to 10.
Then Zoom in in the image.

image
@jleibs jleibs added 🪳 bug Something isn't working 👀 needs triage This issue needs to be triaged by the Rerun team ui concerns graphical user interface and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Jul 19, 2023
@Wumpf
Copy link
Member

Wumpf commented Jul 20, 2023

Seems to be a regression since last release:
Here https://demo.rerun.io/version/latest/examples/structure_from_motion/ it still works and here it doesn't https://demo.rerun.io/pr/2751/examples/structure_from_motion/

@Wumpf Wumpf added 🦟 regression A thing that used to work in an earlier release 🏎️ Quick Issue Can be fixed in a few hours or less labels Jul 20, 2023
@jleibs jleibs mentioned this issue Jul 21, 2023
Closed
11 tasks
@Wumpf
Copy link
Member

Wumpf commented Jul 24, 2023

I think I got this wrong, on main this seems to work fine. There is the smaller problem of point radius not being a radius but a diameter, but otherwise it seems fine:

Screenshots with 100% scaling, meaning pixel size == point size.
Zoomed in:
image
And zoomed out a bit:
image

@jleibs
Copy link
Member Author

jleibs commented Jul 24, 2023

This still repros for me on main. Investigating a bit further, The key appears to be choosing a window aspect ratio such that when zoomed all the way out, the image is scaled based on the horizontal dimension.

image
image

If instead the window is larger than the source image, or the scaling is driven off the vertical dimension, then everything works fine.

@Wumpf
Copy link
Member

Wumpf commented Jul 25, 2023

excellent find/observation. fix coming

@Wumpf Wumpf removed the 🦟 regression A thing that used to work in an earlier release label Jul 25, 2023
@Wumpf Wumpf mentioned this issue Jul 25, 2023
Merged
3 tasks
Wumpf added a commit that referenced this issue Jul 25, 2023
@Wumpf
Fix ui-scale based point/line sizes incorrectly scaled when zooming b…
381a847 
…ased on horizontal dimension (#2805)

### What

Fixes #2758 
* #2758

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2805) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2805)
- [Docs
preview](https://rerun.io/preview/pr%3Aandreas%2Ffix-ui-scale-for-horizontal-scaling/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Aandreas%2Ffix-ui-scale-for-horizontal-scaling/examples)
@abey79 abey79 added this to the 0.8 milestone Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wumpf Wumpf

Labels
🪳 bug Something isn't working 🏎️ Quick Issue Can be fixed in a few hours or less ui concerns graphical user interface
Projects
None yet
Milestone
0.8
3 participants
@Wumpf @jleibs @abey79