Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve design implementation accuracy of viewport views #2737

Closed
2 tasks
Tracked by #2670
, #2780
...
martenbjork opened this issue Jul 18, 2023 · 0 comments · Fixed by #2879
Closed
2 tasks
Tracked by #2670
, #2780
...

Improve design implementation accuracy of viewport views #2737

martenbjork opened this issue Jul 18, 2023 · 0 comments · Fixed by #2879
Labels
ui concerns graphical user interface

Comments

@martenbjork
Copy link
Contributor

martenbjork commented Jul 18, 2023 •
edited
Loading

The title bar, with tabs and icons, is not consistent with the design.

Implementation

image

Design system version 👉 Figma

image

TODO

  • Change the color of the Space View title to Global/Color/Grey/175
  • Change the tab design so that it looks like the design system version (more discrete tabs, add icons)
@martenbjork martenbjork mentioned this issue Jul 18, 2023
Open
25 tasks
@Wumpf Wumpf added the ui concerns graphical user interface label Jul 18, 2023
@martenbjork martenbjork changed the title Remove 1px padding inside space views Improve implementation of viewport views Jul 18, 2023
@jleibs jleibs mentioned this issue Jul 21, 2023
Closed
16 tasks
@martenbjork martenbjork changed the title Improve implementation of viewport views Improve design implementation accuracy of viewport views Jul 28, 2023
@abey79 abey79 mentioned this issue Jul 31, 2023
Merged
7 tasks
abey79 added a commit that referenced this issue Aug 1, 2023
@abey79
Improved space view tab UI (#2879)
08b9e54 
### What

This PR improves the space view tab UI:

- [x] add the space view icon to the tab
- [x] Change the color of the Space View title bar to
Global/Color/Grey/175
- [x] Change the tab design so that it looks like the design system
version (no distinct active tab background)
- [x] Selected tab's background are now fully blue (as opposed to
rounded rect.

The following changes will be subject to a follow-up PR:
1. better look of the "dragged" widget
2. (possibly) reuse of `ReUi::selectable_label_with_icon()` for the
implementation (if it makes sense after (1))

Closes #2737

New design:

<img width="731" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/d4a6718d-c25a-41bb-b4e7-8584080dac4b">

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2879) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2879)
- [Docs
preview](https://rerun.io/preview/pr%3Aantoine%2Fbetter-tabs/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Aantoine%2Fbetter-tabs/examples)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve space view tab design rerun-io/rerun
2 participants
@martenbjork @Wumpf