New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hover effect in selection view toggle #2726

Closed

Tracked by

,

...

martenbjork opened this issue Jul 18, 2023 · 1 comment · Fixed by #2796 or #2864

Closed

Tracked by

,

...

Remove hover effect in selection view toggle #2726

martenbjork opened this issue Jul 18, 2023 · 1 comment · Fixed by #2796 or #2864

Labels

ui

Contributor

martenbjork commented Jul 18, 2023 •

edited

Loading

When hovered, the arrow scales up. It shouldn't.

martenbjork mentioned this issue

Tracking issue: Improve Figma → Implementation accuracy #2670

Open

25 tasks

Wumpf added the ui label

jleibs mentioned this issue

Assorted Design Improvements #2780

Closed

16 tasks

abey79 mentioned this issue

Disable expansion effects in the UI #2796

Merged

3 tasks

abey79 closed this as completed in #2796

abey79 added a commit that referenced this issue


          Disabled expansion effects in the UI (#2796)

9ca1f3b

### What

Fixes #2727
Fixes #2726
Fixes #2730

Questions for the reviewers:
- This affects the popup menu controls. Due to their styling the
expansion effect was invisible, but resulted in the greyed hover area to
be larger by 2px all around. The difference is visible in the videos
below. Is that OK? @martenbjork
- This PR removes the expansion effect from the blueprint tree's
triangles, and the play/pause/etc. buttons (desired, not shown in the
videos below). Did I miss some other, undesirable side-effect elsewhere?

Before:


https://github.com/rerun-io/rerun/assets/49431240/9990dc45-0294-4e04-9331-94eccba4a1d7

After:


https://github.com/rerun-io/rerun/assets/49431240/4fa29bf8-e9cf-4224-8c23-3427474576cc

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2796) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2796)
- [Docs
preview](https://rerun.io/preview/pr%3Aantoine%2Fno-expansion-2727/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Aantoine%2Fno-expansion-2727/examples)

abey79 reopened this

Member

abey79 commented Jul 26, 2023

#2796 reverted by #2824

abey79 added a commit that referenced this issue


          Removed expansion effect from the large collapsing headers

c417fb3

Fixes #2726

abey79 mentioned this issue

Remove expansion effect from the large collapsing headers #2864

Merged

3 tasks

abey79 closed this as completed in #2864

abey79 added a commit that referenced this issue


          Removed the expansion effect from the large collapsing headers (#2864)

1e83dea

### What

Remove the expansion effect on the large collapsible header's triangle.

Fixes #2726

Before:

<img width="178" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/af52e1b4-91cb-4522-af0a-23fda5664929">

After: 

<img width="193" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/fddb8024-fd4f-45b5-94d5-353cf3c6a723">

(Both are being hovered.)

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2864) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2864)
- [Docs
preview](https://rerun.io/preview/pr%3Aantoine%2Fno-expansion-large-header-2726/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Aantoine%2Fno-expansion-large-header-2726/examples)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment