Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcut Ctrl+Shift+S for "Toggle Selection View" open the Save dialog #2605

Closed
asuper0 opened this issue Jul 5, 2023 · 0 comments · Fixed by #2631
Closed

Shortcut Ctrl+Shift+S for "Toggle Selection View" open the Save dialog #2605

asuper0 opened this issue Jul 5, 2023 · 0 comments · Fixed by #2631
Assignees
@emilk
Labels
🪳 bug Something isn't working ui concerns graphical user interface

Comments

@asuper0
Copy link

asuper0 commented Jul 5, 2023

Describe the bug

As is described at top-right of the viewer, Ctrl+Shift+S is for "Toggle Selection View", but it open the Save dialog.

Desktop (please complete the following information):

  • OS: Windows 10

Rerun version

rerun-cli 0.6.0 [rustc 1.69.0 (84c898d65 2023-04-16), LLVM 15.0.7] x86_64-pc-windows-msvc, built 2023-05-26T07:59:51Z
AND
rerun_py 0.7.0 [rustc 1.69.0 (84c898d65 2023-04-16), LLVM 15.0.7] x86_64-pc-windows-msvc prepare-0.7 9cf3033, built 2023-06-16T15:45:38Z
@asuper0 asuper0 added 👀 needs triage This issue needs to be triaged by the Rerun team 🪳 bug Something isn't working labels Jul 5, 2023
@emilk emilk self-assigned this Jul 7, 2023
@emilk emilk added ui concerns graphical user interface and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Jul 7, 2023
@emilk emilk mentioned this issue Jul 7, 2023
Merged
3 tasks
emilk added a commit that referenced this issue Jul 7, 2023
@emilk
Change "Save Selection" command to Cmd+Alt+S (#2631)
97f154c 
Closes #2605
* #2605

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2631) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2631)
- [Docs
preview](https://rerun.io/preview/pr%3Aemilk%2Ffix-overlapping-keyboard-shortcuts/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Aemilk%2Ffix-overlapping-keyboard-shortcuts/examples)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

Labels
🪳 bug Something isn't working ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change "Save Selection" command to Cmd+Alt+S rerun-io/rerun
2 participants
@emilk @asuper0