Selecting a component doesn't highlight anything in the space view(s) #2574
Labels
😤 annoying
Something in the UI / SDK is annoying to use
🏎️ Quick Issue
Can be fixed in a few hours or less
📺 re_viewer
affects re_viewer itself
Comments
Wumpf
added
📺 re_viewer
4 tasks
Wumpf
added a commit
that referenced
this issue
Jan 10, 2024
### What * Fixes #2574 Note that this is implemented internally using what we call a "sibling selection" - we preserve the information that the entity itself within any space view isn't selected directly but only indirectly. Different ui elements can react different to sibling selections versus "real" selections - e.g. the blueprint view does not react to sibling selections. We do however show the full outline in the space view. Took the opportunity to make the space view highlights determination code a bit more readable. Tested it a bit to make sure that the behavior is still the same. ---- <img width="1153" alt="image" src="https://github.com/rerun-io/rerun/assets/1220815/6acd79ac-e3ed-48cf-aa34-c2d98e900d96"> Note the highlight of the points in the space view - this didn't happen before. ---- <img width="1158" alt="image" src="https://github.com/rerun-io/rerun/assets/1220815/739ba24b-9282-472d-9224-98793a3357af"> Similar, hovering highlights are even more generous now, making all entities hover-highlighted whenever an entity component path with the same entity is hovered (subltey: the 0/1/2 on the selection panel in the picture are *not* hover highlighted since they are specific instance paths) --- ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/4748/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/4748/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/4748/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4748) - [Docs preview](https://rerun.io/preview/1f0b646d7d7df95d6ec1512667079bce5759e0f4/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/1f0b646d7d7df95d6ec1512667079bce5759e0f4/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Example: Clicking the
box3dcomponent of a box in api_demo#bbox_demo does not highlight the box in the space view.Highlights should be a bit more liberal and still highlight the entity - yes this would highlight more than the component is about but more often than not that's better.
The text was updated successfully, but these errors were encountered: