Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keypoint skeleton is not visible in human-motion demo on web #2483

Closed
jleibs opened this issue Jun 20, 2023 · 1 comment · Fixed by #2491
Closed

Keypoint skeleton is not visible in human-motion demo on web #2483

jleibs opened this issue Jun 20, 2023 · 1 comment · Fixed by #2491
Labels
🪳 bug Something isn't working examples Issues relating to the Rerun examples 🔺 re_renderer affects re_renderer itself 🕸️ web regarding running the viewer in a browser

Comments

@jleibs
Copy link
Member

jleibs commented Jun 20, 2023

Seems like a layering issue.

If the image is visible we can see keypoints but no skeleton:
image

If we hide the image and mask then the skeleton is visible:
image
@jleibs jleibs added 🪳 bug Something isn't working 🕸️ web regarding running the viewer in a browser 🔺 re_renderer affects re_renderer itself examples Issues relating to the Rerun examples labels Jun 20, 2023
@emilk
Copy link
Member

emilk commented Jun 20, 2023 •
edited
Loading

I can reproduce on Safari on Mac.
On Firefox and Chromium on Mac it works.

frame_idx #69 is especially bad.

Lowering (!) the w_scale_bias multiplier in crates/re_renderer/shader/utils/depth_offset.wgsl seem to help.

64: works frame #69
128-512: works mostly, but not frame #69
Original: 1000.0 - fails on most frames

@emilk emilk mentioned this issue Jun 20, 2023
Merged
1 task
emilk added a commit that referenced this issue Jun 26, 2023
@emilk
Tweak the depth bias multiplier for WebGL (#2491)
e5ccdce 
### What
Closes #2483

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2491

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/12ef481/docs
Examples preview: https://rerun.io/preview/12ef481/examples
<!-- pr-link-docs:end -->
emilk added a commit that referenced this issue Jun 29, 2023
@emilk
Tweak the depth bias multiplier for WebGL (#2491)
f39a53f 
### What
Closes #2483

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2491

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/12ef481/docs
Examples preview: https://rerun.io/preview/12ef481/examples
<!-- pr-link-docs:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🪳 bug Something isn't working examples Issues relating to the Rerun examples 🔺 re_renderer affects re_renderer itself 🕸️ web regarding running the viewer in a browser
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tweak the depth bias multiplier for WebGL rerun-io/rerun
2 participants
@emilk @jleibs